Fix off-by-one error in ParseFormatSpecifier() when reporting the location of a null character.

llvm-svn: 94762

1 files changed, 2 insertions, 3 deletions

diff --git a/clang/lib/Analysis/PrintfFormatString.cpp b/clang/lib/Analysis/PrintfFormatString.cpp
index 544956ac411..986411fc7d2 100644
--- a/clang/lib/Analysis/PrintfFormatString.cpp
+++ b/clang/lib/Analysis/PrintfFormatString.cpp
@@ -89,16 +89,15 @@ static FormatSpecifierResult ParseFormatSpecifier(FormatStringHandler &H,
   UpdateOnReturn <const char*> UpdateBeg(Beg, I);
 
   // Look for a '%' character that indicates the start of a format specifier.
-  while (I != E) {
+  for ( ; I != E ; ++I) {
     char c = *I;
-    ++I;    
     if (c == '\0') {
       // Detect spurious null characters, which are likely errors.
       H.HandleNullChar(I);
       return true;
     }
     if (c == '%') {
-      Start = I;  // Record the start of the format specifier.
+      Start = I++;  // Record the start of the format specifier.
       break;
     }
   }