Don't flag dead stores when the result of a preincrement/predecrement is used in an enclosing expression.

llvm-svn: 53964

1 files changed, 6 insertions, 1 deletions

diff --git a/clang/lib/Analysis/CheckDeadStores.cpp b/clang/lib/Analysis/CheckDeadStores.cpp
index 005c71a5806..433e61154f9 100644
--- a/clang/lib/Analysis/CheckDeadStores.cpp
+++ b/clang/lib/Analysis/CheckDeadStores.cpp
@@ -153,6 +153,11 @@ public:
       if (!U->isIncrementOp())
         return;
       
+      // Don't flag dead stores when the result of a preincrement/predecrement
+      // is used in an enclosing expression.
+      if (U->isPrefix() && Parents.isSubExpr(U))
+        return;
+      
       Expr *Ex = U->getSubExpr()->IgnoreParenCasts();
       
       if (DeclRefExpr* DR = dyn_cast<DeclRefExpr>(Ex))
@@ -161,7 +166,7 @@ public:
     else if (DeclStmt* DS = dyn_cast<DeclStmt>(S))
       // Iterate through the decls.  Warn if any initializers are complex
       // expressions that are not live (never used).
-      for (ScopedDecl* SD = DS->getDecl(); SD; SD = SD->getNextDeclarator()) {        
+      for (ScopedDecl* SD = DS->getDecl(); SD; SD = SD->getNextDeclarator()) {
         
         VarDecl* V = dyn_cast<VarDecl>(SD);
         if (!V) continue;