diff options
| author | Erich Keane <erich.keane@intel.com> | 2017-10-19 15:58:58 +0000 |
|---|---|---|
| committer | Erich Keane <erich.keane@intel.com> | 2017-10-19 15:58:58 +0000 |
| commit | 80b0fb04a6e9ec51e0bd7e021d49a3fa21eaa1cc (patch) | |
| tree | e2c39f8be347e3b702e7d01a489ffdc78b00fceb /clang/lib/AST | |
| parent | f2127d172835149b309eb4f949d2edf6764965a3 (diff) | |
| download | bcm5719-llvm-80b0fb04a6e9ec51e0bd7e021d49a3fa21eaa1cc.tar.gz bcm5719-llvm-80b0fb04a6e9ec51e0bd7e021d49a3fa21eaa1cc.zip | |
Fix nodiscard for volatile references
As reported here https://bugs.llvm.org/show_bug.cgi?id=34988
[[nodiscard]] warnings were not being suppressed for
volatile-ref return values.
Differential Revision: https://reviews.llvm.org/D39075
llvm-svn: 316166
Diffstat (limited to 'clang/lib/AST')
| -rw-r--r-- | clang/lib/AST/Expr.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp index e8aa8f3d33d..6cda82b2b0c 100644 --- a/clang/lib/AST/Expr.cpp +++ b/clang/lib/AST/Expr.cpp @@ -2298,7 +2298,8 @@ bool Expr::isUnusedResultAWarning(const Expr *&WarnE, SourceLocation &Loc, const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(CE->getSubExpr()->IgnoreParens()); if (!(DRE && isa<VarDecl>(DRE->getDecl()) && - cast<VarDecl>(DRE->getDecl())->hasLocalStorage())) { + cast<VarDecl>(DRE->getDecl())->hasLocalStorage()) && + !isa<CallExpr>(CE->getSubExpr()->IgnoreParens())) { return CE->getSubExpr()->isUnusedResultAWarning(WarnE, Loc, R1, R2, Ctx); } |
