diff options
| author | Daniel Dunbar <daniel@zuster.org> | 2010-04-15 06:18:39 +0000 |
|---|---|---|
| committer | Daniel Dunbar <daniel@zuster.org> | 2010-04-15 06:18:39 +0000 |
| commit | 3d9289c736f503d156666ad82c91b9c1df91da7e (patch) | |
| tree | 7bfa640d79606daccb395c3d3e679adc2d398153 /clang/lib/AST/RecordLayoutBuilder.cpp | |
| parent | 3245afdf05234f72721d95fd0cde097255d6814f (diff) | |
| download | bcm5719-llvm-3d9289c736f503d156666ad82c91b9c1df91da7e.tar.gz bcm5719-llvm-3d9289c736f503d156666ad82c91b9c1df91da7e.zip | |
Add TargetInfo::useBitfieldTypeAlignment().
- Used to determine whether the alignment of the type in a bit-field is
respected when laying out structures. The default is true, targets can
override this as needed.
- This is designed to correspond to the PCC_BITFIELD_TYPE_MATTERS macro in
gcc. The AST/Sema implementation only affects one line, unless I have
forgotten something. I'd appreciate further review.
- IRgen still needs to be updated to fully support this (which is effectively
PR5591).
llvm-svn: 101356
Diffstat (limited to 'clang/lib/AST/RecordLayoutBuilder.cpp')
| -rw-r--r-- | clang/lib/AST/RecordLayoutBuilder.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/clang/lib/AST/RecordLayoutBuilder.cpp b/clang/lib/AST/RecordLayoutBuilder.cpp index bb73e7ea11e..d312ee13fec 100644 --- a/clang/lib/AST/RecordLayoutBuilder.cpp +++ b/clang/lib/AST/RecordLayoutBuilder.cpp @@ -585,7 +585,7 @@ void ASTRecordLayoutBuilder::LayoutBitField(const FieldDecl *D) { uint64_t TypeSize = FieldInfo.first; unsigned FieldAlign = FieldInfo.second; - if (FieldPacked) + if (FieldPacked || !Ctx.Target.useBitfieldTypeAlignment()) FieldAlign = 1; if (const AlignedAttr *AA = D->getAttr<AlignedAttr>()) FieldAlign = std::max(FieldAlign, AA->getMaxAlignment()); @@ -594,12 +594,11 @@ void ASTRecordLayoutBuilder::LayoutBitField(const FieldDecl *D) { if (MaxFieldAlignment) FieldAlign = std::min(FieldAlign, MaxFieldAlignment); - // Check if we need to add padding to give the field the correct - // alignment. + // Check if we need to add padding to give the field the correct alignment. if (FieldSize == 0 || (FieldOffset & (FieldAlign-1)) + FieldSize > TypeSize) FieldOffset = (FieldOffset + (FieldAlign-1)) & ~(FieldAlign-1); - // Padding members don't affect overall alignment + // Padding members don't affect overall alignment. if (!D->getIdentifier()) FieldAlign = 1; |

