diff options
| author | Erik Pilkington <erik.pilkington@gmail.com> | 2019-11-18 10:56:05 -0800 |
|---|---|---|
| committer | Erik Pilkington <erik.pilkington@gmail.com> | 2019-11-18 12:15:20 -0800 |
| commit | 8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4 (patch) | |
| tree | 8f00abb332ff6a03bbdb5af8d85e393ca0b873d8 /clang/lib/AST/Expr.cpp | |
| parent | 626260cfe3c7a5d9747f0bf13d87fa1855eb74bb (diff) | |
| download | bcm5719-llvm-8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4.tar.gz bcm5719-llvm-8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4.zip | |
[Sema] Fix a -Wobjc-signed-char-bool false-positive
Unsigned bit-field flags can only have boolean values, so handle that case in
Expr::isKnownToHaveBooleanValue.
rdar://56256999
Diffstat (limited to 'clang/lib/AST/Expr.cpp')
| -rw-r--r-- | clang/lib/AST/Expr.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp index 3438c3aadc6..4fd5fed5bee 100644 --- a/clang/lib/AST/Expr.cpp +++ b/clang/lib/AST/Expr.cpp @@ -191,6 +191,12 @@ bool Expr::isKnownToHaveBooleanValue() const { if (const auto *OVE = dyn_cast<OpaqueValueExpr>(E)) return OVE->getSourceExpr()->isKnownToHaveBooleanValue(); + if (const FieldDecl *FD = E->getSourceBitField()) + if (FD->getType()->isUnsignedIntegerType() && + !FD->getBitWidth()->isValueDependent() && + FD->getBitWidthValue(FD->getASTContext()) == 1) + return true; + return false; } |
