diff options
author | Benjamin Kramer <benny.kra@googlemail.com> | 2013-11-10 16:55:11 +0000 |
---|---|---|
committer | Benjamin Kramer <benny.kra@googlemail.com> | 2013-11-10 16:55:11 +0000 |
commit | eed8061b9fdebaefa4531035de6c544e1a031f0a (patch) | |
tree | 0b9d8de4774b095e27a668bb2bc1c3983ccfc9c5 /clang/lib/AST/CommentSema.cpp | |
parent | 70e2e17872e74cff7b54ef3114f9d2bbcf31bdd9 (diff) | |
download | bcm5719-llvm-eed8061b9fdebaefa4531035de6c544e1a031f0a.tar.gz bcm5719-llvm-eed8061b9fdebaefa4531035de6c544e1a031f0a.zip |
Avoid double StringMap lookups. No functionality change.
llvm-svn: 194355
Diffstat (limited to 'clang/lib/AST/CommentSema.cpp')
-rw-r--r-- | clang/lib/AST/CommentSema.cpp | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/clang/lib/AST/CommentSema.cpp b/clang/lib/AST/CommentSema.cpp index d5110f1131b..1c6222f9ec0 100644 --- a/clang/lib/AST/CommentSema.cpp +++ b/clang/lib/AST/CommentSema.cpp @@ -314,17 +314,15 @@ void Sema::actOnTParamCommandParamNameArg(TParamCommandComment *Command, SmallVector<unsigned, 2> Position; if (resolveTParamReference(Arg, TemplateParameters, &Position)) { Command->setPosition(copyArray(llvm::makeArrayRef(Position))); - llvm::StringMap<TParamCommandComment *>::iterator PrevCommandIt = - TemplateParameterDocs.find(Arg); - if (PrevCommandIt != TemplateParameterDocs.end()) { + TParamCommandComment *&PrevCommand = TemplateParameterDocs[Arg]; + if (PrevCommand) { SourceRange ArgRange(ArgLocBegin, ArgLocEnd); Diag(ArgLocBegin, diag::warn_doc_tparam_duplicate) << Arg << ArgRange; - TParamCommandComment *PrevCommand = PrevCommandIt->second; Diag(PrevCommand->getLocation(), diag::note_doc_tparam_previous) << PrevCommand->getParamNameRange(); } - TemplateParameterDocs[Arg] = Command; + PrevCommand = Command; return; } |