summaryrefslogtreecommitdiffstats
path: root/clang/lib/AST/ASTImporter.cpp
diff options
context:
space:
mode:
authorGabor Marton <gabor.marton@ericsson.com>2019-06-11 13:35:25 +0000
committerGabor Marton <gabor.marton@ericsson.com>2019-06-11 13:35:25 +0000
commitdd2b76e13eb8da90bce124d65092bfaff65fe6c0 (patch)
treee077cbde4b637fb520f48a007fc4a9dfd215e4b8 /clang/lib/AST/ASTImporter.cpp
parent963d73ff44d68cf3b350b771f26b7fcd2f943a46 (diff)
downloadbcm5719-llvm-dd2b76e13eb8da90bce124d65092bfaff65fe6c0.tar.gz
bcm5719-llvm-dd2b76e13eb8da90bce124d65092bfaff65fe6c0.zip
[ASTImporter] Fix unhandled cases in ASTImporterLookupTable
Summary: In most cases the FriendDecl contains the declaration of the befriended class as a child node, so it is discovered during the recursive visitation. However, there are cases when the befriended class is not a child, thus it must be fetched explicitly from the FriendDecl, and only then can we add it to the lookup table. (Note, this does affect only CTU and does not affect LLDB, because we cannot and do not use the ASTImporterLookupTable in LLDB.) Reviewers: a_sidorin, a.sidorin, shafik Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D62064 llvm-svn: 363062
Diffstat (limited to 'clang/lib/AST/ASTImporter.cpp')
-rw-r--r--clang/lib/AST/ASTImporter.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/clang/lib/AST/ASTImporter.cpp b/clang/lib/AST/ASTImporter.cpp
index 1f1ec1d687c..e0a9da5d2ad 100644
--- a/clang/lib/AST/ASTImporter.cpp
+++ b/clang/lib/AST/ASTImporter.cpp
@@ -2256,7 +2256,8 @@ ASTNodeImporter::VisitTypedefNameDecl(TypedefNameDecl *D, bool IsAlias) {
if (!FromUT->isIncompleteType() && !FoundUT->isIncompleteType())
return Importer.MapImported(D, FoundTypedef);
}
- // FIXME Handle redecl chain.
+ // FIXME Handle redecl chain. When you do that make consistent changes
+ // in ASTImporterLookupTable too.
break;
}
OpenPOWER on IntegriCloud