diff options
author | Argyrios Kyrtzidis <akyrtzi@gmail.com> | 2011-11-06 18:57:57 +0000 |
---|---|---|
committer | Argyrios Kyrtzidis <akyrtzi@gmail.com> | 2011-11-06 18:57:57 +0000 |
commit | aaa999660bd94735a369cd6edf185718015ee71d (patch) | |
tree | 47575b4fc5fb4bde46eacce8ff8a897775d83e6c /clang/lib/ARCMigrate | |
parent | b7e86d4ee2beddfd964bb77fdf33553c898e59ba (diff) | |
download | bcm5719-llvm-aaa999660bd94735a369cd6edf185718015ee71d.tar.gz bcm5719-llvm-aaa999660bd94735a369cd6edf185718015ee71d.zip |
[arcmt] Refactor PropertiesRewriter to use MigrationContext.
llvm-svn: 143882
Diffstat (limited to 'clang/lib/ARCMigrate')
-rw-r--r-- | clang/lib/ARCMigrate/TransProperties.cpp | 6 | ||||
-rw-r--r-- | clang/lib/ARCMigrate/Transforms.cpp | 12 | ||||
-rw-r--r-- | clang/lib/ARCMigrate/Transforms.h | 21 |
3 files changed, 35 insertions, 4 deletions
diff --git a/clang/lib/ARCMigrate/TransProperties.cpp b/clang/lib/ARCMigrate/TransProperties.cpp index db34ee27a56..6f9166fb983 100644 --- a/clang/lib/ARCMigrate/TransProperties.cpp +++ b/clang/lib/ARCMigrate/TransProperties.cpp @@ -526,6 +526,8 @@ public: } // anonymous namespace -void trans::rewriteProperties(MigrationPass &pass) { - ImplementationChecker(pass).TraverseDecl(pass.Ctx.getTranslationUnitDecl()); +void PropertyRewriteTraverser::traverseObjCImplementation( + ObjCImplementationContext &ImplCtx) { + PropertiesRewriter(ImplCtx.getMigrationContext().getPass()) + .doTransform(ImplCtx.getImplementationDecl()); } diff --git a/clang/lib/ARCMigrate/Transforms.cpp b/clang/lib/ARCMigrate/Transforms.cpp index d0c9bc69c85..5ea454a917d 100644 --- a/clang/lib/ARCMigrate/Transforms.cpp +++ b/clang/lib/ARCMigrate/Transforms.cpp @@ -302,6 +302,16 @@ class ASTTransform : public RecursiveASTVisitor<ASTTransform> { public: ASTTransform(MigrationContext &MigrateCtx) : MigrateCtx(MigrateCtx) { } + bool TraverseObjCImplementationDecl(ObjCImplementationDecl *D) { + ObjCImplementationContext ImplCtx(MigrateCtx, D); + for (MigrationContext::traverser_iterator + I = MigrateCtx.traversers_begin(), + E = MigrateCtx.traversers_end(); I != E; ++I) + (*I)->traverseObjCImplementation(ImplCtx); + + return true; + } + bool TraverseStmt(Stmt *rootS) { if (!rootS) return true; @@ -358,13 +368,13 @@ static void traverseAST(MigrationPass &pass) { if (pass.isGCMigration()) { MigrateCtx.addTraverser(new GCCollectableCallsTraverser); } + MigrateCtx.addTraverser(new PropertyRewriteTraverser()); MigrateCtx.traverse(pass.Ctx.getTranslationUnitDecl()); } static void independentTransforms(MigrationPass &pass) { rewriteAutoreleasePool(pass); - rewriteProperties(pass); removeRetainReleaseDeallocFinalize(pass); rewriteUnusedInitDelegate(pass); removeZeroOutPropsInDeallocFinalize(pass); diff --git a/clang/lib/ARCMigrate/Transforms.h b/clang/lib/ARCMigrate/Transforms.h index 515844656a0..4ff35a5daf0 100644 --- a/clang/lib/ARCMigrate/Transforms.h +++ b/clang/lib/ARCMigrate/Transforms.h @@ -37,7 +37,6 @@ void rewriteUnbridgedCasts(MigrationPass &pass); void makeAssignARCSafe(MigrationPass &pass); void removeRetainReleaseDeallocFinalize(MigrationPass &pass); void removeZeroOutPropsInDeallocFinalize(MigrationPass &pass); -void rewriteProperties(MigrationPass &pass); void rewriteBlockObjCVariable(MigrationPass &pass); void rewriteUnusedInitDelegate(MigrationPass &pass); void checkAPIUses(MigrationPass &pass); @@ -58,10 +57,25 @@ public: Stmt *getTopStmt() { return TopStmt; } }; +class ObjCImplementationContext { + MigrationContext &MigrateCtx; + ObjCImplementationDecl *ImpD; + +public: + ObjCImplementationContext(MigrationContext &MigrateCtx, + ObjCImplementationDecl *D) + : MigrateCtx(MigrateCtx), ImpD(D) {} + + MigrationContext &getMigrationContext() { return MigrateCtx; } + ObjCImplementationDecl *getImplementationDecl() { return ImpD; } +}; + class ASTTraverser { public: virtual ~ASTTraverser(); + virtual void traverseTU(MigrationContext &MigrateCtx) { } virtual void traverseBody(BodyContext &BodyCtx) { } + virtual void traverseObjCImplementation(ObjCImplementationContext &ImplCtx) {} }; class MigrationContext { @@ -87,6 +101,11 @@ public: void traverse(TranslationUnitDecl *TU); }; +class PropertyRewriteTraverser : public ASTTraverser { +public: + virtual void traverseObjCImplementation(ObjCImplementationContext &ImplCtx); +}; + // GC transformations class GCCollectableCallsTraverser : public ASTTraverser { |