diff options
| author | David Blaikie <dblaikie@gmail.com> | 2012-04-30 02:36:29 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2012-04-30 02:36:29 +0000 |
| commit | 2d7c57ec1dca2ca678d086b545c4cf38091d0902 (patch) | |
| tree | 3568bffdf992022c819331a278aec3ae60696215 /clang/lib/ARCMigrate/TransGCAttrs.cpp | |
| parent | 13ef0cfd6976f54c5922be4ee2aaa4dac4395959 (diff) | |
| download | bcm5719-llvm-2d7c57ec1dca2ca678d086b545c4cf38091d0902.tar.gz bcm5719-llvm-2d7c57ec1dca2ca678d086b545c4cf38091d0902.zip | |
Remove the ref/value inconsistency in filter_decl_iterator.
filter_decl_iterator had a weird mismatch where both op* and op-> returned T*
making it difficult to generalize this filtering behavior into a reusable
library of any kind.
This change errs on the side of value, making op-> return T* and op* return
T&.
(reviewed by Richard Smith)
llvm-svn: 155808
Diffstat (limited to 'clang/lib/ARCMigrate/TransGCAttrs.cpp')
| -rw-r--r-- | clang/lib/ARCMigrate/TransGCAttrs.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/ARCMigrate/TransGCAttrs.cpp b/clang/lib/ARCMigrate/TransGCAttrs.cpp index 9f6066ef77d..a206683bc3d 100644 --- a/clang/lib/ARCMigrate/TransGCAttrs.cpp +++ b/clang/lib/ARCMigrate/TransGCAttrs.cpp @@ -136,7 +136,7 @@ public: if (CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(D)) { for (CXXRecordDecl::method_iterator MI = RD->method_begin(), ME = RD->method_end(); MI != ME; ++MI) { - if ((*MI)->isOutOfLine()) + if (MI->isOutOfLine()) return true; } return false; |
