summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra
diff options
context:
space:
mode:
authorKadir Cetinkaya <kadircet@google.com>2020-01-24 11:35:24 +0100
committerKadir Cetinkaya <kadircet@google.com>2020-01-27 16:39:28 +0100
commit99464b7eb1d7bbeb7380a6ccc19b0ffdb2f08d40 (patch)
tree5cf7be9fc793730fe513592053f260e72399efb4 /clang-tools-extra
parent53f39c77b2ba74626b0dfd5efbfdf39b2f0d720e (diff)
downloadbcm5719-llvm-99464b7eb1d7bbeb7380a6ccc19b0ffdb2f08d40.tar.gz
bcm5719-llvm-99464b7eb1d7bbeb7380a6ccc19b0ffdb2f08d40.zip
[clangd][Hover] Change arrow in return type back to →
Summary: Currently 🡺 is used in hover response to represent return types, but it is not widely available. Changing this back to original to support more clients. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D73336 (cherry picked from commit 1b996faa1575bda6b99e778aaabe14834c10d3ff)
Diffstat (limited to 'clang-tools-extra')
-rw-r--r--clang-tools-extra/clangd/Hover.cpp4
-rw-r--r--clang-tools-extra/clangd/test/hover.test2
-rw-r--r--clang-tools-extra/clangd/unittests/HoverTests.cpp2
3 files changed, 4 insertions, 4 deletions
diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp
index 8ce67018fd3..95468aeab0e 100644
--- a/clang-tools-extra/clangd/Hover.cpp
+++ b/clang-tools-extra/clangd/Hover.cpp
@@ -540,11 +540,11 @@ markup::Document HoverInfo::present() const {
// editor, as they might be long.
if (ReturnType) {
// For functions we display signature in a list form, e.g.:
- // 🡺 `x`
+ // → `x`
// Parameters:
// - `bool param1`
// - `int param2 = 5`
- Output.addParagraph().appendText("🡺").appendCode(*ReturnType);
+ Output.addParagraph().appendText("→").appendCode(*ReturnType);
if (Parameters && !Parameters->empty()) {
Output.addParagraph().appendText("Parameters:");
markup::BulletList &L = Output.addBulletList();
diff --git a/clang-tools-extra/clangd/test/hover.test b/clang-tools-extra/clangd/test/hover.test
index 79f7a010014..ec8d0488fa5 100644
--- a/clang-tools-extra/clangd/test/hover.test
+++ b/clang-tools-extra/clangd/test/hover.test
@@ -9,7 +9,7 @@
# CHECK-NEXT: "result": {
# CHECK-NEXT: "contents": {
# CHECK-NEXT: "kind": "plaintext",
-# CHECK-NEXT: "value": "function foo\n\n🡺 void\n\nvoid foo()"
+# CHECK-NEXT: "value": "function foo\n\n→ void\n\nvoid foo()"
# CHECK-NEXT: },
# CHECK-NEXT: "range": {
# CHECK-NEXT: "end": {
diff --git a/clang-tools-extra/clangd/unittests/HoverTests.cpp b/clang-tools-extra/clangd/unittests/HoverTests.cpp
index 67257bac639..acbfc827b2a 100644
--- a/clang-tools-extra/clangd/unittests/HoverTests.cpp
+++ b/clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -1762,7 +1762,7 @@ template <typename T, typename C = bool> class Foo {})",
},
R"(function foo
-🡺 ret_type
+→ ret_type
Parameters:
-
- type
OpenPOWER on IntegriCloud