summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra
diff options
context:
space:
mode:
authorDaniel Jasper <djasper@google.com>2014-05-23 08:52:10 +0000
committerDaniel Jasper <djasper@google.com>2014-05-23 08:52:10 +0000
commit39f9f726bcc27f8f125cc8078d33f818b2d54eee (patch)
tree1e72104adab63cf8e3ed575274d8331f9caa760a /clang-tools-extra
parent84242dc774be3fae8a9a9f2712e6f37b150aeecc (diff)
downloadbcm5719-llvm-39f9f726bcc27f8f125cc8078d33f818b2d54eee.tar.gz
bcm5719-llvm-39f9f726bcc27f8f125cc8078d33f818b2d54eee.zip
clang-tidy: Only add 'override' before inlined bodies.
llvm-svn: 209505
Diffstat (limited to 'clang-tools-extra')
-rw-r--r--clang-tools-extra/clang-tidy/misc/UseOverride.cpp3
-rw-r--r--clang-tools-extra/test/clang-tidy/use-override.cpp3
2 files changed, 5 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp
index c8974daa16c..628c20f4a22 100644
--- a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp
+++ b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp
@@ -96,7 +96,8 @@ void UseOverride::check(const MatchFinder::MatchResult &Result) {
}
}
- if (InsertLoc.isInvalid() && Method->getBody()) {
+ if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody() &&
+ Method->getBody()) {
InsertLoc = Method->getBody()->getLocStart();
}
diff --git a/clang-tools-extra/test/clang-tidy/use-override.cpp b/clang-tools-extra/test/clang-tidy/use-override.cpp
index df0ab24d4ee..25c5a6a6c40 100644
--- a/clang-tools-extra/test/clang-tidy/use-override.cpp
+++ b/clang-tools-extra/test/clang-tidy/use-override.cpp
@@ -59,6 +59,9 @@ public:
void SimpleCases::i() {}
// CHECK: {{^void SimpleCases::i\(\) {}}}
+SimpleCases::~SimpleCases() {}
+// CHECK: {{^SimpleCases::~SimpleCases\(\) {}}}
+
struct InlineDefinitions : public Base {
public:
virtual ~InlineDefinitions() {}
OpenPOWER on IntegriCloud