diff options
author | Alexander Kornienko <alexfh@google.com> | 2018-03-15 08:26:19 +0000 |
---|---|---|
committer | Alexander Kornienko <alexfh@google.com> | 2018-03-15 08:26:19 +0000 |
commit | 3273888536db25dd5cd3d2e7ebc5138632e6e8a8 (patch) | |
tree | 00981ad8cb8e718480708cd568f57859d1ec5e46 /clang-tools-extra | |
parent | 7ff60761296f7797967843a5169f1634f3d5c431 (diff) | |
download | bcm5719-llvm-3273888536db25dd5cd3d2e7ebc5138632e6e8a8.tar.gz bcm5719-llvm-3273888536db25dd5cd3d2e7ebc5138632e6e8a8.zip |
[clang-tidy] rename_check.py misc-sizeof-expression bugprone-sizeof-expression
llvm-svn: 327607
Diffstat (limited to 'clang-tools-extra')
-rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp | 3 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt | 1 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp (renamed from clang-tools-extra/clang-tidy/misc/SizeofExpressionCheck.cpp) | 4 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.h (renamed from clang-tools-extra/clang-tidy/misc/SizeofExpressionCheck.h) | 12 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/misc/CMakeLists.txt | 1 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp | 3 | ||||
-rw-r--r-- | clang-tools-extra/docs/ReleaseNotes.rst | 3 | ||||
-rw-r--r-- | clang-tools-extra/docs/clang-tidy/checks/bugprone-sizeof-expression.rst (renamed from clang-tools-extra/docs/clang-tidy/checks/misc-sizeof-expression.rst) | 6 | ||||
-rw-r--r-- | clang-tools-extra/docs/clang-tidy/checks/list.rst | 2 | ||||
-rw-r--r-- | clang-tools-extra/test/clang-tidy/bugprone-sizeof-expression.cpp (renamed from clang-tools-extra/test/clang-tidy/misc-sizeof-expression.cpp) | 2 |
10 files changed, 20 insertions, 17 deletions
diff --git a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp index 4b530e7f3b5..922a79d064a 100644 --- a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp @@ -28,6 +28,7 @@ #include "MisplacedWideningCastCheck.h" #include "MoveForwardingReferenceCheck.h" #include "MultipleStatementMacroCheck.h" +#include "SizeofExpressionCheck.h" #include "StringConstructorCheck.h" #include "StringIntegerAssignmentCheck.h" #include "StringLiteralWithEmbeddedNulCheck.h" @@ -86,6 +87,8 @@ public: "bugprone-move-forwarding-reference"); CheckFactories.registerCheck<MultipleStatementMacroCheck>( "bugprone-multiple-statement-macro"); + CheckFactories.registerCheck<SizeofExpressionCheck>( + "bugprone-sizeof-expression"); CheckFactories.registerCheck<StringConstructorCheck>( "bugprone-string-constructor"); CheckFactories.registerCheck<StringIntegerAssignmentCheck>( diff --git a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt index 1fad72e9ff7..4bd83a92994 100644 --- a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt +++ b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt @@ -20,6 +20,7 @@ add_clang_library(clangTidyBugproneModule MisplacedWideningCastCheck.cpp MoveForwardingReferenceCheck.cpp MultipleStatementMacroCheck.cpp + SizeofExpressionCheck.cpp StringConstructorCheck.cpp StringIntegerAssignmentCheck.cpp StringLiteralWithEmbeddedNulCheck.cpp diff --git a/clang-tools-extra/clang-tidy/misc/SizeofExpressionCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp index 5b8e7e7632a..d389ff155e0 100644 --- a/clang-tools-extra/clang-tidy/misc/SizeofExpressionCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp @@ -16,7 +16,7 @@ using namespace clang::ast_matchers; namespace clang { namespace tidy { -namespace misc { +namespace bugprone { namespace { @@ -260,6 +260,6 @@ void SizeofExpressionCheck::check(const MatchFinder::MatchResult &Result) { } } -} // namespace misc +} // namespace bugprone } // namespace tidy } // namespace clang diff --git a/clang-tools-extra/clang-tidy/misc/SizeofExpressionCheck.h b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.h index d2ba9daf38e..2811b5afc96 100644 --- a/clang-tools-extra/clang-tidy/misc/SizeofExpressionCheck.h +++ b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.h @@ -7,19 +7,19 @@ // //===----------------------------------------------------------------------===// -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_SIZEOFEXPRESSIONCHECK_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_SIZEOFEXPRESSIONCHECK_H #include "../ClangTidy.h" namespace clang { namespace tidy { -namespace misc { +namespace bugprone { /// Find suspicious usages of sizeof expression. /// /// For the user-facing documentation see: -/// http://clang.llvm.org/extra/clang-tidy/checks/misc-sizeof-expression.html +/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-sizeof-expression.html class SizeofExpressionCheck : public ClangTidyCheck { public: SizeofExpressionCheck(StringRef Name, ClangTidyContext *Context); @@ -33,8 +33,8 @@ private: const bool WarnOnSizeOfCompareToConstant; }; -} // namespace misc +} // namespace bugprone } // namespace tidy } // namespace clang -#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_SIZEOF_EXPRESSION_H +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_SIZEOFEXPRESSIONCHECK_H diff --git a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt index 023288e7295..4d8cedd81da 100644 --- a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt +++ b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt @@ -9,7 +9,6 @@ add_clang_library(clangTidyMiscModule NonCopyableObjects.cpp RedundantExpressionCheck.cpp SizeofContainerCheck.cpp - SizeofExpressionCheck.cpp StaticAssertCheck.cpp ThrowByValueCatchByReferenceCheck.cpp UniqueptrResetReleaseCheck.cpp diff --git a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp index a5f017ee719..9a9ebb6f9d2 100644 --- a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp @@ -16,7 +16,6 @@ #include "NonCopyableObjects.h" #include "RedundantExpressionCheck.h" #include "SizeofContainerCheck.h" -#include "SizeofExpressionCheck.h" #include "StaticAssertCheck.h" #include "ThrowByValueCatchByReferenceCheck.h" #include "UnconventionalAssignOperatorCheck.h" @@ -45,8 +44,6 @@ public: CheckFactories.registerCheck<RedundantExpressionCheck>( "misc-redundant-expression"); CheckFactories.registerCheck<SizeofContainerCheck>("misc-sizeof-container"); - CheckFactories.registerCheck<SizeofExpressionCheck>( - "misc-sizeof-expression"); CheckFactories.registerCheck<StaticAssertCheck>("misc-static-assert"); CheckFactories.registerCheck<ThrowByValueCatchByReferenceCheck>( "misc-throw-by-value-catch-by-reference"); diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index 1ca0a0b4971..fa1a6e01be4 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -137,6 +137,9 @@ Improvements to clang-tidy - The 'misc-misplaced-widening-cast' check was renamed to `bugprone-misplaced-widening-cast <http://clang.llvm.org/extra/clang-tidy/checks/bugprone-misplaced-widening-cast.html>`_ +- The 'misc-sizeof-expression' check was renamed to `bugprone-sizeof-expression + <http://clang.llvm.org/extra/clang-tidy/checks/bugprone-sizeof-expression.html>`_ + - The 'misc-string-compare' check was renamed to `readability-string-compare <http://clang.llvm.org/extra/clang-tidy/checks/readability-string-compare.html>`_ diff --git a/clang-tools-extra/docs/clang-tidy/checks/misc-sizeof-expression.rst b/clang-tools-extra/docs/clang-tidy/checks/bugprone-sizeof-expression.rst index d3e3790025a..8190c009edd 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/misc-sizeof-expression.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/bugprone-sizeof-expression.rst @@ -1,7 +1,7 @@ -.. title:: clang-tidy - misc-sizeof-expression +.. title:: clang-tidy - bugprone-sizeof-expression -misc-sizeof-expression -====================== +bugprone-sizeof-expression +========================== The check finds usages of ``sizeof`` expressions which are most likely errors. diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst index 3e2006e908a..b30a41d71d9 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/list.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst @@ -36,6 +36,7 @@ Clang-Tidy Checks bugprone-misplaced-widening-cast bugprone-move-forwarding-reference bugprone-multiple-statement-macro + bugprone-sizeof-expression bugprone-string-constructor bugprone-string-integer-assignment bugprone-string-literal-with-embedded-nul @@ -146,7 +147,6 @@ Clang-Tidy Checks misc-non-copyable-objects misc-redundant-expression misc-sizeof-container - misc-sizeof-expression misc-static-assert misc-throw-by-value-catch-by-reference misc-unconventional-assign-operator diff --git a/clang-tools-extra/test/clang-tidy/misc-sizeof-expression.cpp b/clang-tools-extra/test/clang-tidy/bugprone-sizeof-expression.cpp index f9d798ded0d..1a14f6880ae 100644 --- a/clang-tools-extra/test/clang-tidy/misc-sizeof-expression.cpp +++ b/clang-tools-extra/test/clang-tidy/bugprone-sizeof-expression.cpp @@ -1,4 +1,4 @@ -// RUN: %check_clang_tidy %s misc-sizeof-expression %t +// RUN: %check_clang_tidy %s bugprone-sizeof-expression %t class C { int size() { return sizeof(this); } |