diff options
| author | NAKAMURA Takumi <geek4civic@gmail.com> | 2015-08-20 15:04:39 +0000 |
|---|---|---|
| committer | NAKAMURA Takumi <geek4civic@gmail.com> | 2015-08-20 15:04:39 +0000 |
| commit | 1544a819b7af84fe99219214ebabe93ab9636426 (patch) | |
| tree | 7db4dadb4a277a679b99de6661301a7370c79ade /clang-tools-extra | |
| parent | ba598b5581e9dd169a967161e2dfad239a92c79f (diff) | |
| download | bcm5719-llvm-1544a819b7af84fe99219214ebabe93ab9636426.tar.gz bcm5719-llvm-1544a819b7af84fe99219214ebabe93ab9636426.zip | |
Tweak clang-tools-extra/test/clang-tidy/file-filter.cpp to pass on win32.
FIXME: "-I %S/Inputs/file-filter/system/.." must be redundant.
On Win32, file-filter/system\system-header1.h precedes file-filter\header*.h due to code order between '/' and '\\'.
We should remove such a tweak to introduce the *right* path canonicalization.
Posix:
file-filter/header*.h
file-filter/system/system-header1.h
Win32:
file-filter/system\system-header1.h
file-filter\header*.h
Win32, tweaked:
file-filter/system/..\header*.h
file-filter/system\system-header1.h
It had been disabled since r220837.
llvm-svn: 245566
Diffstat (limited to 'clang-tools-extra')
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/file-filter.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/clang-tools-extra/test/clang-tidy/file-filter.cpp b/clang-tools-extra/test/clang-tidy/file-filter.cpp index 6f301e4090d..0c9f3a22b24 100644 --- a/clang-tools-extra/test/clang-tidy/file-filter.cpp +++ b/clang-tools-extra/test/clang-tidy/file-filter.cpp @@ -1,7 +1,10 @@ // RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter='' %s -- -I %S/Inputs/file-filter -isystem %S/Inputs/file-filter/system 2>&1 | FileCheck %s // RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter='.*' %s -- -I %S/Inputs/file-filter -isystem %S/Inputs/file-filter/system 2>&1 | FileCheck --check-prefix=CHECK2 %s // RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter='header2\.h' %s -- -I %S/Inputs/file-filter -isystem %S/Inputs/file-filter/system 2>&1 | FileCheck --check-prefix=CHECK3 %s -// RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter='.*' -system-headers %s -- -I %S/Inputs/file-filter -isystem %S/Inputs/file-filter/system 2>&1 | FileCheck --check-prefix=CHECK4 %s +// FIXME: "-I %S/Inputs/file-filter/system/.." must be redundant. +// On Win32, file-filter/system\system-header1.h precedes +// file-filter\header*.h due to code order between '/' and '\\'. +// RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter='.*' -system-headers %s -- -I %S/Inputs/file-filter/system/.. -isystem %S/Inputs/file-filter/system 2>&1 | FileCheck --check-prefix=CHECK4 %s #include "header1.h" // CHECK-NOT: warning: @@ -40,6 +43,3 @@ class A { A(int); }; // CHECK3: Use -header-filter=.* {{.*}} // CHECK4-NOT: Suppressed {{.*}} warnings // CHECK4-NOT: Use -header-filter=.* {{.*}} - -// FIXME: It doesn't pass on win32. Investigating. -// REQUIRES: shell |
