diff options
author | Alexander Kornienko <alexfh@google.com> | 2014-05-05 18:49:31 +0000 |
---|---|---|
committer | Alexander Kornienko <alexfh@google.com> | 2014-05-05 18:49:31 +0000 |
commit | 4aab579d0758c16b8293aa5960c0d33a38b648ae (patch) | |
tree | aff53447f2769fe7b10656f4a556f6f32d4af6be /clang-tools-extra/unittests/clang-tidy | |
parent | 75f34c1386f6ee8e3d28f6c3f30b83d2bb7f6584 (diff) | |
download | bcm5719-llvm-4aab579d0758c16b8293aa5960c0d33a38b648ae.tar.gz bcm5719-llvm-4aab579d0758c16b8293aa5960c0d33a38b648ae.zip |
Fix assertion in google-explicit-constructor check when the constructor is
defined in a macro.
Summary:
We shouldn't suggest replacements in macros anyway, as we can't see all
usages of the macro and ensure the replacement is safe for all of them.
Reviewers: klimek
Reviewed By: klimek
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D3611
llvm-svn: 207987
Diffstat (limited to 'clang-tools-extra/unittests/clang-tidy')
-rw-r--r-- | clang-tools-extra/unittests/clang-tidy/GoogleModuleTest.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/clang-tools-extra/unittests/clang-tidy/GoogleModuleTest.cpp b/clang-tools-extra/unittests/clang-tidy/GoogleModuleTest.cpp index d986d3bcb04..89e47407c98 100644 --- a/clang-tools-extra/unittests/clang-tidy/GoogleModuleTest.cpp +++ b/clang-tools-extra/unittests/clang-tidy/GoogleModuleTest.cpp @@ -47,6 +47,15 @@ TEST(ExplicitConstructorCheckTest, RemoveExplicit) { "class C { explicit/*asdf*/ C(const C&, int i = 0); };")); } +TEST(ExplicitConstructorCheckTest, RemoveExplicitWithMacros) { + EXPECT_EQ( + "#define A(T) class T##Bar { explicit T##Bar(const T##Bar &b) {} };\n" + "A(Foo);", + runCheckOnCode<ExplicitConstructorCheck>( + "#define A(T) class T##Bar { explicit T##Bar(const T##Bar &b) {} };\n" + "A(Foo);")); +} + } // namespace test } // namespace tidy } // namespace clang |