diff options
author | NAKAMURA Takumi <geek4civic@gmail.com> | 2017-07-13 02:06:30 +0000 |
---|---|---|
committer | NAKAMURA Takumi <geek4civic@gmail.com> | 2017-07-13 02:06:30 +0000 |
commit | 02d34adfd832b468ed0f6e33d38a1298080a2a65 (patch) | |
tree | 9362556f510b70f26dce8e27b88036bdd134f3d2 /clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp | |
parent | 8050ea16b55992ef7bf8e2e30530d9aff2851a18 (diff) | |
download | bcm5719-llvm-02d34adfd832b468ed0f6e33d38a1298080a2a65.tar.gz bcm5719-llvm-02d34adfd832b468ed0f6e33d38a1298080a2a65.zip |
clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp: Resolve flakiness in the test.
Tests would go flaky if;
1. Using %T (not %t)
2. Put a file with common name like header.h into %T
3. Other tests (eg. misc-unused-parameters.cpp) are doing as well
We should avoid using %T unless it really makes sense.
llvm-svn: 307876
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp')
-rw-r--r-- | clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp b/clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp index 661abde46e0..9e4c24650f6 100644 --- a/clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp +++ b/clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp @@ -1,6 +1,8 @@ -// RUN: cp %S/Inputs/performance-unnecessary-value-param/header.h %T/header.h -// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t -- -- -std=c++11 -I %T -// RUN: diff %T/header.h %S/Inputs/performance-unnecessary-value-param/header-fixed.h +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: cp %S/Inputs/performance-unnecessary-value-param/header.h %t/header.h +// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t/temp -- -- -std=c++11 -I %t +// RUN: diff %t/header.h %S/Inputs/performance-unnecessary-value-param/header-fixed.h #include "header.h" |