summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/test/clang-tidy/modernize-make-shared.cpp
diff options
context:
space:
mode:
authorAlexander Kornienko <alexfh@google.com>2018-10-09 15:58:18 +0000
committerAlexander Kornienko <alexfh@google.com>2018-10-09 15:58:18 +0000
commitc968c988806b3acf612ffa645f570ef62860c9d9 (patch)
tree0078afb79f2642e4a2d9ce7e2fb073e937d1fdf1 /clang-tools-extra/test/clang-tidy/modernize-make-shared.cpp
parenta461174cfd36859423fe75f7b4c17b32ce1f41ee (diff)
downloadbcm5719-llvm-c968c988806b3acf612ffa645f570ef62860c9d9.tar.gz
bcm5719-llvm-c968c988806b3acf612ffa645f570ef62860c9d9.zip
[clang-tidy] Fix handling of parens around new expressions in make_<smartptr> checks.
Summary: Extra parentheses around a new expression result in incorrect code after applying fixes. Reviewers: hokein Reviewed By: hokein Subscribers: xazax.hun, cfe-commits Differential Revision: https://reviews.llvm.org/D52989 llvm-svn: 344058
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/modernize-make-shared.cpp')
-rw-r--r--clang-tools-extra/test/clang-tidy/modernize-make-shared.cpp12
1 files changed, 12 insertions, 0 deletions
diff --git a/clang-tools-extra/test/clang-tidy/modernize-make-shared.cpp b/clang-tools-extra/test/clang-tidy/modernize-make-shared.cpp
index ed4da998ec5..49012dc1858 100644
--- a/clang-tools-extra/test/clang-tidy/modernize-make-shared.cpp
+++ b/clang-tools-extra/test/clang-tidy/modernize-make-shared.cpp
@@ -70,6 +70,18 @@ void basic() {
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: use std::make_shared instead
// CHECK-FIXES: auto P3 = std::make_shared<int>();
+ std::shared_ptr<int> P4 = std::shared_ptr<int>((new int));
+ // CHECK-MESSAGES: :[[@LINE-1]]:29: warning: use std::make_shared instead [modernize-make-shared]
+ // CHECK-FIXES: std::shared_ptr<int> P4 = std::make_shared<int>();
+
+ P4.reset((((new int()))));
+ // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: use std::make_shared instead [modernize-make-shared]
+ // CHECK-FIXES: P4 = std::make_shared<int>();
+
+ P4 = std::shared_ptr<int>(((new int)));
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: use std::make_shared instead [modernize-make-shared]
+ // CHECK-FIXES: P4 = std::make_shared<int>();
+
{
// No std.
using namespace std;
OpenPOWER on IntegriCloud