diff options
| author | Alexander Kornienko <alexfh@google.com> | 2015-03-15 02:19:37 +0000 |
|---|---|---|
| committer | Alexander Kornienko <alexfh@google.com> | 2015-03-15 02:19:37 +0000 |
| commit | 1c4af5edf4e92f1436b6668ab665dea42d512834 (patch) | |
| tree | e26920756f51b1d22b4698bd863d981bb60f6b6e /clang-tools-extra/test/clang-tidy/misc-static-assert.cpp | |
| parent | b0464089fd7c36c8c1179dbdbd0ec000a0b3d6a8 (diff) | |
| download | bcm5719-llvm-1c4af5edf4e92f1436b6668ab665dea42d512834.tar.gz bcm5719-llvm-1c4af5edf4e92f1436b6668ab665dea42d512834.zip | |
[clang-tidy] Fix false positives in the misc-static-assert check http://llvm.org/PR22880
The misc-static-assert check will not warn on assert(false), assert(False),
assert(FALSE); where false / False / FALSE are macros expanding to the false or
0 literals.
Also added corresponding test cases.
http://reviews.llvm.org/D8328
Patch by Szabolcs Sipos!
llvm-svn: 232306
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/misc-static-assert.cpp')
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/misc-static-assert.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/clang-tools-extra/test/clang-tidy/misc-static-assert.cpp b/clang-tools-extra/test/clang-tidy/misc-static-assert.cpp index e17a701b06a..040515a1182 100644 --- a/clang-tools-extra/test/clang-tidy/misc-static-assert.cpp +++ b/clang-tools-extra/test/clang-tidy/misc-static-assert.cpp @@ -12,6 +12,9 @@ void abort() {} #define ZERO_MACRO 0 +#define False false +#define FALSE 0 + #define my_macro() assert(0 == 1) // CHECK-FIXES: #define my_macro() assert(0 == 1) @@ -60,6 +63,11 @@ int main() { assert(false); // CHECK-FIXES: {{^ }}assert(false); + assert(False); + // CHECK-FIXES: {{^ }}assert(False); + assert(FALSE); + // CHECK-FIXES: {{^ }}assert(FALSE); + assert(ZERO_MACRO); // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() that could be // CHECK-FIXES: {{^ }}static_assert(ZERO_MACRO, ""); |
