diff options
author | Samuel Benzaquen <sbenza@google.com> | 2016-03-21 18:00:43 +0000 |
---|---|---|
committer | Samuel Benzaquen <sbenza@google.com> | 2016-03-21 18:00:43 +0000 |
commit | bd6a74e1facb648f2d4dd94ac0f1a62f6dc2b44b (patch) | |
tree | 8f55dae40f856cffa25f4e6acd0c80e095ab2170 /clang-tools-extra/test/clang-tidy/misc-inefficient-algorithm.cpp | |
parent | 86b9fbe980dde2c93b59314d87434aebcdcd79a2 (diff) | |
download | bcm5719-llvm-bd6a74e1facb648f2d4dd94ac0f1a62f6dc2b44b.tar.gz bcm5719-llvm-bd6a74e1facb648f2d4dd94ac0f1a62f6dc2b44b.zip |
[clang-tidy] Fix check broken in rL263822.
Add names missing from rL263822 and add tests to prevent future omissions.
llvm-svn: 263963
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/misc-inefficient-algorithm.cpp')
-rw-r--r-- | clang-tools-extra/test/clang-tidy/misc-inefficient-algorithm.cpp | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/clang-tools-extra/test/clang-tidy/misc-inefficient-algorithm.cpp b/clang-tools-extra/test/clang-tidy/misc-inefficient-algorithm.cpp index df962c9195c..75ca7d64738 100644 --- a/clang-tools-extra/test/clang-tidy/misc-inefficient-algorithm.cpp +++ b/clang-tools-extra/test/clang-tidy/misc-inefficient-algorithm.cpp @@ -35,7 +35,11 @@ template <typename K, typename V, typename Cmp = less<K>> struct map { iterator end() const; }; +template <typename K, typename V> struct multimap : map<K, V> {}; template <typename K> struct unordered_set : set<K> {}; +template <typename K, typename V> struct unordered_map : map<K, V> {}; +template <typename K> struct unordered_multiset : set<K> {}; +template <typename K, typename V> struct unordered_multimap : map<K, V> {}; template <typename K, typename Cmp = less<K>> struct multiset : set<K, Cmp> {}; @@ -114,10 +118,30 @@ int main() { // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: this STL algorithm call should be // CHECK-FIXES: {{^ }}us.find(10);{{$}} + std::unordered_multiset<int> ums; + find(ums.begin(), ums.end(), 10); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: this STL algorithm call should be + // CHECK-FIXES: {{^ }}ums.find(10);{{$}} + std::map<int, int> intmap; find(intmap.begin(), intmap.end(), 46); // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: this STL algorithm call should be // CHECK-FIXES: {{^ }}find(intmap.begin(), intmap.end(), 46);{{$}} + + std::multimap<int, int> intmmap; + find(intmmap.begin(), intmmap.end(), 46); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: this STL algorithm call should be + // CHECK-FIXES: {{^ }}find(intmmap.begin(), intmmap.end(), 46);{{$}} + + std::unordered_map<int, int> umap; + find(umap.begin(), umap.end(), 46); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: this STL algorithm call should be + // CHECK-FIXES: {{^ }}find(umap.begin(), umap.end(), 46);{{$}} + + std::unordered_multimap<int, int> ummap; + find(ummap.begin(), ummap.end(), 46); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: this STL algorithm call should be + // CHECK-FIXES: {{^ }}find(ummap.begin(), ummap.end(), 46);{{$}} } struct Value { |