diff options
| author | Stephane Moore <mog@google.com> | 2018-12-14 03:13:31 +0000 |
|---|---|---|
| committer | Stephane Moore <mog@google.com> | 2018-12-14 03:13:31 +0000 |
| commit | b69ece899d60c5397a884442733c93fa6cf0824b (patch) | |
| tree | a9fb7b7ece337c58b6db44a9b451e51da7dd0f19 /clang-tools-extra/test/clang-tidy/google-objc-function-naming.mm | |
| parent | 918adb56d865df7896d3c5514066ebff476bd612 (diff) | |
| download | bcm5719-llvm-b69ece899d60c5397a884442733c93fa6cf0824b.tar.gz bcm5719-llvm-b69ece899d60c5397a884442733c93fa6cf0824b.zip | |
[clang-tidy] Improve google-objc-function-naming diagnostics 📙
Summary:
The diagnostics from google-objc-function-naming check will be more
actionable if they provide a brief description of the requirements from
the Google Objective-C style guide. The more descriptive diagnostics may
help clarify that functions in the global namespace must have an
appropriate prefix followed by Pascal case (engineers working previously
with static functions might not immediately understand the different
requirements of static and non-static functions).
Test Notes:
Verified against the clang-tidy tests.
Reviewers: benhamilton, aaron.ballman
Reviewed By: benhamilton
Subscribers: MyDeveloperDay, xazax.hun, cfe-commits
Differential Revision: https://reviews.llvm.org/D55482
llvm-svn: 349123
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/google-objc-function-naming.mm')
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/google-objc-function-naming.mm | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/clang-tools-extra/test/clang-tidy/google-objc-function-naming.mm b/clang-tools-extra/test/clang-tidy/google-objc-function-naming.mm index 2e894575528..43c2d7ebf67 100644 --- a/clang-tools-extra/test/clang-tidy/google-objc-function-naming.mm +++ b/clang-tools-extra/test/clang-tidy/google-objc-function-naming.mm @@ -1,16 +1,19 @@ // RUN: %check_clang_tidy %s google-objc-function-naming %t void printSomething() {} -// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function name 'printSomething' not -// using function naming conventions described by Google Objective-C style guide +// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function in global namespace named +// 'printSomething' must have an appropriate prefix followed by Pascal case as +// required by Google Objective-C style guide void PrintSomething() {} -// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function name 'PrintSomething' not -// using function naming conventions described by Google Objective-C style guide +// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function in global namespace named +// 'PrintSomething' must have an appropriate prefix followed by Pascal case as +// required by Google Objective-C style guide void ABCBad_Name() {} -// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function name 'ABCBad_Name' not -// using function naming conventions described by Google Objective-C style guide +// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function in global namespace named +// 'ABCBad_Name' must have an appropriate prefix followed by Pascal case as +// required by Google Objective-C style guide namespace { |
