diff options
author | Dmitri Gribenko <gribozavr@gmail.com> | 2019-10-11 12:05:42 +0000 |
---|---|---|
committer | Dmitri Gribenko <gribozavr@gmail.com> | 2019-10-11 12:05:42 +0000 |
commit | 885c559369fe3d6323898c17787bd0454065fc34 (patch) | |
tree | ba43b987e078f4c2a033acc71ad3d7f1ee385a11 /clang-tools-extra/test/clang-tidy/android-cloexec-socket.cpp | |
parent | 9f6a873268e1ad9855873d9d8007086c0d01cf4f (diff) | |
download | bcm5719-llvm-885c559369fe3d6323898c17787bd0454065fc34.tar.gz bcm5719-llvm-885c559369fe3d6323898c17787bd0454065fc34.zip |
[ClangTidy] Separate tests for infrastructure and checkers
Summary:
This change moves tests for checkers and infrastructure into separate
directories, making it easier to find infrastructure tests. Tests for
checkers are already easy to find because they are named after the
checker. Tests for infrastructure were difficult to find because they
were outnumbered by tests for checkers. Now they are in a separate
directory.
Reviewers: jfb, jdoerfert, lebedev.ri
Subscribers: srhines, nemanjai, aheejin, kbarton, christof, mgrang, arphaman, jfb, lebedev.ri, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D68807
llvm-svn: 374540
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/android-cloexec-socket.cpp')
-rw-r--r-- | clang-tools-extra/test/clang-tidy/android-cloexec-socket.cpp | 75 |
1 files changed, 0 insertions, 75 deletions
diff --git a/clang-tools-extra/test/clang-tidy/android-cloexec-socket.cpp b/clang-tools-extra/test/clang-tidy/android-cloexec-socket.cpp deleted file mode 100644 index 25f332d3138..00000000000 --- a/clang-tools-extra/test/clang-tidy/android-cloexec-socket.cpp +++ /dev/null @@ -1,75 +0,0 @@ -// RUN: %check_clang_tidy %s android-cloexec-socket %t - -#define SOCK_STREAM 1 -#define SOCK_DGRAM 2 -#define __O_CLOEXEC 3 -#define SOCK_CLOEXEC __O_CLOEXEC -#define TEMP_FAILURE_RETRY(exp) \ - ({ \ - int _rc; \ - do { \ - _rc = (exp); \ - } while (_rc == -1); \ - }) - -extern "C" int socket(int domain, int type, int protocol); - -void a() { - socket(0, SOCK_STREAM, 0); - // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: 'socket' should use SOCK_CLOEXEC where possible [android-cloexec-socket] - // CHECK-FIXES: socket(0, SOCK_STREAM | SOCK_CLOEXEC, 0) - TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM, 0)); - // CHECK-MESSAGES: :[[@LINE-1]]:43: warning: 'socket' - // CHECK-FIXES: TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM | SOCK_CLOEXEC, 0)) - socket(0, SOCK_STREAM | SOCK_DGRAM, 0); - // CHECK-MESSAGES: :[[@LINE-1]]:37: warning: 'socket' - // CHECK-FIXES: socket(0, SOCK_STREAM | SOCK_DGRAM | SOCK_CLOEXEC, 0) - TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM | SOCK_DGRAM, 0)); - // CHECK-MESSAGES: :[[@LINE-1]]:56: warning: 'socket' - // CHECK-FIXES: TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM | SOCK_DGRAM | SOCK_CLOEXEC, 0)) -} - -void f() { - socket(0, 3, 0); - // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: 'socket' - // CHECK-FIXES: socket(0, 3 | SOCK_CLOEXEC, 0) - TEMP_FAILURE_RETRY(socket(0, 3, 0)); - // CHECK-MESSAGES: :[[@LINE-1]]:33: warning: 'socket' - // CHECK-FIXES: TEMP_FAILURE_RETRY(socket(0, 3 | SOCK_CLOEXEC, 0)) - - int flag = 3; - socket(0, flag, 0); - TEMP_FAILURE_RETRY(socket(0, flag, 0)); -} - -namespace i { -int socket(int domain, int type, int protocol); - -void d() { - socket(0, SOCK_STREAM, 0); - TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM, 0)); - socket(0, SOCK_STREAM | SOCK_DGRAM, 0); - TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM | SOCK_DGRAM, 0)); -} - -} // namespace i - -void e() { - socket(0, SOCK_CLOEXEC, 0); - TEMP_FAILURE_RETRY(socket(0, SOCK_CLOEXEC, 0)); - socket(0, SOCK_STREAM | SOCK_CLOEXEC, 0); - TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM | SOCK_CLOEXEC, 0)); - socket(0, SOCK_STREAM | SOCK_CLOEXEC | SOCK_DGRAM, 0); - TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM | SOCK_CLOEXEC | SOCK_DGRAM, 0)); -} - -class G { -public: - int socket(int domain, int type, int protocol); - void d() { - socket(0, SOCK_STREAM, 0); - TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM, 0)); - socket(0, SOCK_STREAM | SOCK_DGRAM, 0); - TEMP_FAILURE_RETRY(socket(0, SOCK_STREAM | SOCK_DGRAM, 0)); - } -}; |