diff options
author | John Thompson <John.Thompson.JTSoftware@gmail.com> | 2013-03-12 18:51:47 +0000 |
---|---|---|
committer | John Thompson <John.Thompson.JTSoftware@gmail.com> | 2013-03-12 18:51:47 +0000 |
commit | 1f67ccb3fd2c4a4b29730dfcad21220039132444 (patch) | |
tree | 6dfdc00b2bd251b849af45574ffde9cb8d708904 /clang-tools-extra/modularize/Modularize.cpp | |
parent | 14a029d9f3cc777c0c0488f4919071518d0fc003 (diff) | |
download | bcm5719-llvm-1f67ccb3fd2c4a4b29730dfcad21220039132444.tar.gz bcm5719-llvm-1f67ccb3fd2c4a4b29730dfcad21220039132444.zip |
Review feedback change per Edwin: Move non-public members to end of classes.
llvm-svn: 176883
Diffstat (limited to 'clang-tools-extra/modularize/Modularize.cpp')
-rw-r--r-- | clang-tools-extra/modularize/Modularize.cpp | 31 |
1 files changed, 15 insertions, 16 deletions
diff --git a/clang-tools-extra/modularize/Modularize.cpp b/clang-tools-extra/modularize/Modularize.cpp index 7d4d0c3204d..c446bfd17fd 100644 --- a/clang-tools-extra/modularize/Modularize.cpp +++ b/clang-tools-extra/modularize/Modularize.cpp @@ -145,9 +145,6 @@ struct HeaderEntry { typedef std::vector<HeaderEntry> HeaderContents; class EntityMap : public llvm::StringMap<llvm::SmallVector<Entry, 2> > { - llvm::DenseMap<const FileEntry *, HeaderContents> CurHeaderContents; - llvm::DenseMap<const FileEntry *, HeaderContents> AllHeaderContents; - public: llvm::DenseMap<const FileEntry *, HeaderContents> HeaderContentMismatches; @@ -197,14 +194,14 @@ public: CurHeaderContents.clear(); } +private: + llvm::DenseMap<const FileEntry *, HeaderContents> CurHeaderContents; + llvm::DenseMap<const FileEntry *, HeaderContents> AllHeaderContents; }; class CollectEntitiesVisitor : public RecursiveASTVisitor<CollectEntitiesVisitor> { - SourceManager &SM; - EntityMap &Entities; - public: CollectEntitiesVisitor(SourceManager &SM, EntityMap &Entities) : SM(SM), Entities(Entities) { } @@ -249,12 +246,12 @@ public: Entities.add(Name, isa<TagDecl>(ND)? Entry::Tag : Entry::Value, Loc); return true; } +private: + SourceManager &SM; + EntityMap &Entities; }; class CollectEntitiesConsumer : public ASTConsumer { - EntityMap &Entities; - Preprocessor &PP; - public: CollectEntitiesConsumer(EntityMap &Entities, Preprocessor &PP) : Entities(Entities), PP(PP) { } @@ -280,30 +277,32 @@ public: // Merge header contents. Entities.mergeCurHeaderContents(); } +private: + EntityMap &Entities; + Preprocessor &PP; }; class CollectEntitiesAction : public SyntaxOnlyAction { - EntityMap &Entities; - +public: + CollectEntitiesAction(EntityMap &Entities) : Entities(Entities) { } protected: virtual clang::ASTConsumer *CreateASTConsumer(CompilerInstance &CI, StringRef InFile) { return new CollectEntitiesConsumer(Entities, CI.getPreprocessor()); } - -public: - CollectEntitiesAction(EntityMap &Entities) : Entities(Entities) { } +private: + EntityMap &Entities; }; class ModularizeFrontendActionFactory : public FrontendActionFactory { - EntityMap &Entities; - public: ModularizeFrontendActionFactory(EntityMap &Entities) : Entities(Entities) { } virtual CollectEntitiesAction *create() { return new CollectEntitiesAction(Entities); } +private: + EntityMap &Entities; }; int main(int argc, const char **argv) { |