diff options
author | Roman Lebedev <lebedev.ri@gmail.com> | 2018-02-27 15:19:28 +0000 |
---|---|---|
committer | Roman Lebedev <lebedev.ri@gmail.com> | 2018-02-27 15:19:28 +0000 |
commit | 6b56a11961c56d893faee0a6655aafbf588e2e17 (patch) | |
tree | 0f9e8a55801a6ad320882e1cdd6b5dba8b39b85c /clang-tools-extra/modularize/CoverageChecker.cpp | |
parent | 6017bf4f315f9a49a2512cef0d640197172659b3 (diff) | |
download | bcm5719-llvm-6b56a11961c56d893faee0a6655aafbf588e2e17.tar.gz bcm5719-llvm-6b56a11961c56d893faee0a6655aafbf588e2e17.zip |
[Tooling] [1/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>
Summary:
I'm not sure whether there are any principal reasons why it returns raw owning pointer,
or it is just a old code that was not updated post-C++11.
I'm not too sure what testing i should do, because `check-all` is not error clean here for some reason,
but it does not //appear// asif those failures are related to these changes.
This is Clang-tools-extra part.
Clang part is D43779.
Reviewers: klimek, bkramer, alexfh, pcc
Reviewed By: alexfh
Subscribers: ioeric, jkorous-apple, cfe-commits
Tags: #clang, #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D43780
llvm-svn: 326202
Diffstat (limited to 'clang-tools-extra/modularize/CoverageChecker.cpp')
-rw-r--r-- | clang-tools-extra/modularize/CoverageChecker.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clang-tools-extra/modularize/CoverageChecker.cpp b/clang-tools-extra/modularize/CoverageChecker.cpp index 3687872871c..3c406889c69 100644 --- a/clang-tools-extra/modularize/CoverageChecker.cpp +++ b/clang-tools-extra/modularize/CoverageChecker.cpp @@ -129,8 +129,8 @@ public: CoverageCheckerFrontendActionFactory(CoverageChecker &Checker) : Checker(Checker) {} - CoverageCheckerAction *create() override { - return new CoverageCheckerAction(Checker); + std::unique_ptr<clang::FrontendAction> create() override { + return llvm::make_unique<CoverageCheckerAction>(Checker); } private: |