diff options
author | Reid Kleckner <rnk@google.com> | 2017-08-10 21:21:15 +0000 |
---|---|---|
committer | Reid Kleckner <rnk@google.com> | 2017-08-10 21:21:15 +0000 |
commit | 8d4d57035fd50c36d050585d22b50171c49fc6d9 (patch) | |
tree | ccdf78dc0f195d01def6c49d57ed64ff9ac8e563 /clang-tools-extra/docs/clang-tidy/checks/android-cloexec-memfd-create.rst | |
parent | 6be1ed05c7a7e1e7a812f037b660ec693c5c1ca9 (diff) | |
download | bcm5719-llvm-8d4d57035fd50c36d050585d22b50171c49fc6d9.tar.gz bcm5719-llvm-8d4d57035fd50c36d050585d22b50171c49fc6d9.zip |
Revert "[clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module."
This reverts commit r310630.
The new code broke on Windows and was untested. On Linux, it was
selecting the "int" overload of operator<<, which definitely does not
print the right thing when fed a "Mode" char.
llvm-svn: 310661
Diffstat (limited to 'clang-tools-extra/docs/clang-tidy/checks/android-cloexec-memfd-create.rst')
-rw-r--r-- | clang-tools-extra/docs/clang-tidy/checks/android-cloexec-memfd-create.rst | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/clang-tools-extra/docs/clang-tidy/checks/android-cloexec-memfd-create.rst b/clang-tools-extra/docs/clang-tidy/checks/android-cloexec-memfd-create.rst deleted file mode 100644 index a45321d64b3..00000000000 --- a/clang-tools-extra/docs/clang-tidy/checks/android-cloexec-memfd-create.rst +++ /dev/null @@ -1,18 +0,0 @@ -.. title:: clang-tidy - android-cloexec-memfd-create - -android-cloexec-memfd-create -============================ - -``memfd_create()`` should include ``MFD_CLOEXEC`` in its type argument to avoid -the file descriptor leakage. Without this flag, an opened sensitive file would -remain open across a fork+exec to a lower-privileged SELinux domain. - -Examples: - -.. code-block:: c++ - - memfd_create(name, MFD_ALLOW_SEALING); - - // becomes - - memfd_create(name, MFD_ALLOW_SEALING | MFD_CLOEXEC); |