diff options
| author | Fangrui Song <maskray@google.com> | 2018-11-02 05:59:29 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2018-11-02 05:59:29 +0000 |
| commit | 12e4ee79391f982114d1462fe26e63a077897db7 (patch) | |
| tree | bfffb7877d77dba79a3bf706196fe0510bbeeaab /clang-tools-extra/clangd/CodeComplete.cpp | |
| parent | a3ed05b06b0cdaeccb174f209dfa7748e4312bfc (diff) | |
| download | bcm5719-llvm-12e4ee79391f982114d1462fe26e63a077897db7.tar.gz bcm5719-llvm-12e4ee79391f982114d1462fe26e63a077897db7.zip | |
[clangd] Really fix clang -Wimplicit-fallthrough
The intention was to fall through to Function case in LLVM_ENABLE_ASSERTIONS=Off builds.
Use #ifndef NDEBUG to fix -Wimplicit-fallthrough
llvm-svn: 345953
Diffstat (limited to 'clang-tools-extra/clangd/CodeComplete.cpp')
| -rw-r--r-- | clang-tools-extra/clangd/CodeComplete.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/clang-tools-extra/clangd/CodeComplete.cpp b/clang-tools-extra/clangd/CodeComplete.cpp index 3bfde6136de..fec91e12ead 100644 --- a/clang-tools-extra/clangd/CodeComplete.cpp +++ b/clang-tools-extra/clangd/CodeComplete.cpp @@ -218,8 +218,11 @@ struct CompletionCandidate { case index::SymbolKind::ClassMethod: case index::SymbolKind::InstanceMethod: case index::SymbolKind::StaticMethod: - assert(false && "Don't expect members from index in code completion"); +#ifndef NDEBUG + llvm_unreachable("Don't expect members from index in code completion"); +#else LLVM_FALLTHROUGH; +#endif case index::SymbolKind::Function: // We can't group overloads together that need different #includes. // This could break #include insertion. |
