summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
diff options
context:
space:
mode:
authorEhud Katz <ehudkatz@gmail.com>2020-01-06 10:51:55 +0200
committerEhud Katz <ehudkatz@gmail.com>2020-01-06 11:30:40 +0200
commitf3f7dc3d2990151a78b246a7a1485d0c13a9fb36 (patch)
tree72be159dc861918752f1a8dc35297d62fc9d322c /clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
parentaab72f89b19ae38ea7ac3b7b51aae68fc10aef4f (diff)
downloadbcm5719-llvm-f3f7dc3d2990151a78b246a7a1485d0c13a9fb36.tar.gz
bcm5719-llvm-f3f7dc3d2990151a78b246a7a1485d0c13a9fb36.zip
[APFloat] Fix compilation warnings
Diffstat (limited to 'clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp')
-rw-r--r--clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp8
1 files changed, 6 insertions, 2 deletions
diff --git a/clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp b/clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
index 64806cee37e..231e565f27e 100644
--- a/clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
@@ -86,11 +86,15 @@ MagicNumbersCheck::MagicNumbersCheck(StringRef Name, ClangTidyContext *Context)
IgnoredDoublePointValues.reserve(IgnoredFloatingPointValuesInput.size());
for (const auto &InputValue : IgnoredFloatingPointValuesInput) {
llvm::APFloat FloatValue(llvm::APFloat::IEEEsingle());
- FloatValue.convertFromString(InputValue, DefaultRoundingMode);
+ if (!FloatValue.convertFromString(InputValue, DefaultRoundingMode)) {
+ assert(false && "Invalid floating point representation");
+ }
IgnoredFloatingPointValues.push_back(FloatValue.convertToFloat());
llvm::APFloat DoubleValue(llvm::APFloat::IEEEdouble());
- DoubleValue.convertFromString(InputValue, DefaultRoundingMode);
+ if (!DoubleValue.convertFromString(InputValue, DefaultRoundingMode)) {
+ assert(false && "Invalid floating point representation");
+ }
IgnoredDoublePointValues.push_back(DoubleValue.convertToDouble());
}
llvm::sort(IgnoredFloatingPointValues.begin(),
OpenPOWER on IntegriCloud