diff options
| author | Tyker <tyker1@outlook.com> | 2019-11-17 11:41:55 +0100 |
|---|---|---|
| committer | Tyker <tyker1@outlook.com> | 2019-11-19 18:20:45 +0100 |
| commit | b0561b3346e7bf0ae974995ca95b917eebde18e1 (patch) | |
| tree | 959dcae1398035f974b55bbef71fb1b81417be28 /clang-tools-extra/clang-tidy/performance | |
| parent | dd471dbe99a7e017357809151df56f2d4c3e7a31 (diff) | |
| download | bcm5719-llvm-b0561b3346e7bf0ae974995ca95b917eebde18e1.tar.gz bcm5719-llvm-b0561b3346e7bf0ae974995ca95b917eebde18e1.zip | |
[NFC] Refactor representation of materialized temporaries
Summary:
this patch refactor representation of materialized temporaries to prevent an issue raised by rsmith in https://reviews.llvm.org/D63640#inline-612718
Reviewers: rsmith, martong, shafik
Reviewed By: rsmith
Subscribers: thakis, sammccall, ilya-biryukov, rnkovacs, arphaman, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69360
Diffstat (limited to 'clang-tools-extra/clang-tidy/performance')
| -rw-r--r-- | clang-tools-extra/clang-tidy/performance/ImplicitConversionInLoopCheck.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/performance/ImplicitConversionInLoopCheck.cpp b/clang-tools-extra/clang-tidy/performance/ImplicitConversionInLoopCheck.cpp index e3b90d3b427..a5206554091 100644 --- a/clang-tools-extra/clang-tidy/performance/ImplicitConversionInLoopCheck.cpp +++ b/clang-tools-extra/clang-tidy/performance/ImplicitConversionInLoopCheck.cpp @@ -78,7 +78,7 @@ void ImplicitConversionInLoopCheck::check( // iterator returns a value instead of a reference, and the loop variable // is a reference. This situation is fine (it probably produces the same // code at the end). - if (IsNonTrivialImplicitCast(Materialized->getTemporary())) + if (IsNonTrivialImplicitCast(Materialized->getSubExpr())) ReportAndFix(Result.Context, VD, OperatorCall); } |
