diff options
| author | Felix Berger <flx@google.com> | 2016-12-02 14:44:16 +0000 |
|---|---|---|
| committer | Felix Berger <flx@google.com> | 2016-12-02 14:44:16 +0000 |
| commit | e4ab0602f214dda9955a07aa8fc7ea4e68e5a867 (patch) | |
| tree | 01f18cfe9122eb959b5aced9c211ebd7cf45b4d6 /clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp | |
| parent | 3a19863f1c308d59cdecffdf18997dadff09a33e (diff) | |
| download | bcm5719-llvm-e4ab0602f214dda9955a07aa8fc7ea4e68e5a867.tar.gz bcm5719-llvm-e4ab0602f214dda9955a07aa8fc7ea4e68e5a867.zip | |
[clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final
Summary: Virtual method overrides of dependent types cannot be recognized unless
they are marked as override or final.
Exclude methods marked as final from check and add test.
Reviewers: sbenza, hokein, alexfh
Subscribers: malcolm.parsons, JDevlieghere, cfe-commits
Differential Revision: https://reviews.llvm.org/D27248
llvm-svn: 288502
Diffstat (limited to 'clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp')
| -rw-r--r-- | clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp b/clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp index ec99b3a366a..5d746d6ab77 100644 --- a/clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp +++ b/clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp @@ -61,7 +61,8 @@ void UnnecessaryValueParamCheck::registerMatchers(MatchFinder *Finder) { unless(referenceType())))), decl().bind("param")); Finder->addMatcher( - functionDecl(isDefinition(), unless(cxxMethodDecl(isOverride())), + functionDecl(isDefinition(), + unless(cxxMethodDecl(anyOf(isOverride(), isFinal()))), unless(isInstantiated()), has(typeLoc(forEach(ExpensiveValueParamDecl))), decl().bind("functionDecl")), |
