diff options
author | Yan Zhang <ynzhang@google.com> | 2018-05-04 18:14:08 +0000 |
---|---|---|
committer | Yan Zhang <ynzhang@google.com> | 2018-05-04 18:14:08 +0000 |
commit | 4f9ead2356e47f6816e2f88eb91ed1d47acbd245 (patch) | |
tree | df9f0d22af185b5b9afb36f7367caf6a74d48cc8 /clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp | |
parent | bf4c41c7e18ddac1328f7873e2ff8d209a96bd50 (diff) | |
download | bcm5719-llvm-4f9ead2356e47f6816e2f88eb91ed1d47acbd245.tar.gz bcm5719-llvm-4f9ead2356e47f6816e2f88eb91ed1d47acbd245.zip |
Add support for ObjC property name to be a single acronym.
Summary:
This change will support cases like:
```
@property(assign, nonatomic) int ID;
```
Reviewers: benhamilton, hokein
Reviewed By: benhamilton
Subscribers: klimek, cfe-commits
Tags: #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D46374
llvm-svn: 331545
Diffstat (limited to 'clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp')
-rw-r--r-- | clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp b/clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp index fd15df9dea1..cafeac42ba1 100644 --- a/clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp +++ b/clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp @@ -217,6 +217,12 @@ void PropertyDeclarationCheck::check(const MatchFinder::MatchResult &Result) { assert(MatchedDecl->getName().size() > 0); auto *DeclContext = MatchedDecl->getDeclContext(); auto *CategoryDecl = llvm::dyn_cast<ObjCCategoryDecl>(DeclContext); + + auto AcronymsRegex = + llvm::Regex("^" + AcronymsGroupRegex(EscapedAcronyms) + "$"); + if (AcronymsRegex.match(MatchedDecl->getName())) { + return; + } if (CategoryDecl != nullptr && hasCategoryPropertyPrefix(MatchedDecl->getName())) { if (!prefixedPropertyNameValid(MatchedDecl->getName(), EscapedAcronyms) || |