diff options
| author | Daniel Jasper <djasper@google.com> | 2014-05-30 13:31:14 +0000 |
|---|---|---|
| committer | Daniel Jasper <djasper@google.com> | 2014-05-30 13:31:14 +0000 |
| commit | a2332425c4bd5581c6a25ba8a1c0b0a25865f269 (patch) | |
| tree | e9c910fc2169cd1b162643881b1f2ff292e7e05c /clang-tools-extra/clang-tidy/misc/UseOverride.cpp | |
| parent | 86f60b7266f915c2e1b937fee9bfa874bc8909ce (diff) | |
| download | bcm5719-llvm-a2332425c4bd5581c6a25ba8a1c0b0a25865f269.tar.gz bcm5719-llvm-a2332425c4bd5581c6a25ba8a1c0b0a25865f269.zip | |
Revert "Remove redundant check discovered in post-commit review of r209505."
This breaks with MSVC.
With IsLateTemplateParsed, FunctionDecl::doesThisDeclarationHaveABody() returns true regardless of Body.
This reinstates what was fixed in r208985.
llvm-svn: 209896
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/UseOverride.cpp')
| -rw-r--r-- | clang-tools-extra/clang-tidy/misc/UseOverride.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp index 4e4ae27f5ca..628c20f4a22 100644 --- a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp +++ b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp @@ -96,8 +96,10 @@ void UseOverride::check(const MatchFinder::MatchResult &Result) { } } - if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody()) + if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody() && + Method->getBody()) { InsertLoc = Method->getBody()->getLocStart(); + } if (!InsertLoc.isValid()) { if (Tokens.size() > 2 && GetText(Tokens.back(), Sources) == "0" && |
