diff options
| author | Daniel Jasper <djasper@google.com> | 2014-06-04 08:26:02 +0000 |
|---|---|---|
| committer | Daniel Jasper <djasper@google.com> | 2014-06-04 08:26:02 +0000 |
| commit | 0ab7902755ee5edebd548bb1490d60d4878420a1 (patch) | |
| tree | d0048ebf7928731514806c949f786a72e09708eb /clang-tools-extra/clang-tidy/misc/UseOverride.cpp | |
| parent | 91f5b262684dbe2dd0dbf7c6d10840a8cbcc1880 (diff) | |
| download | bcm5719-llvm-0ab7902755ee5edebd548bb1490d60d4878420a1.tar.gz bcm5719-llvm-0ab7902755ee5edebd548bb1490d60d4878420a1.zip | |
clang-tidy use override: Don't generate incorrect warnings without fixes
Add basic testing for the emitted diagnostics.
llvm-svn: 210171
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/UseOverride.cpp')
| -rw-r--r-- | clang-tools-extra/clang-tidy/misc/UseOverride.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp index b2dc912b44c..32f3d7c1d5c 100644 --- a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp +++ b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp @@ -61,7 +61,8 @@ void UseOverride::check(const MatchFinder::MatchResult &Result) { Method->isOutOfLine()) return; - if (Method->getAttr<clang::OverrideAttr>() != nullptr && + if ((Method->getAttr<clang::OverrideAttr>() != nullptr || + Method->getAttr<clang::FinalAttr>() != nullptr) && !Method->isVirtualAsWritten()) return; // Nothing to do. |
