summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-tidy/misc/SuspiciousMissingCommaCheck.h
diff options
context:
space:
mode:
authorEtienne Bergeron <etienneb@google.com>2016-04-04 15:46:38 +0000
committerEtienne Bergeron <etienneb@google.com>2016-04-04 15:46:38 +0000
commit1eec3f01f07c88325f9958b85dee8d33f548af52 (patch)
tree821a09582cb898b9258a18fdf5b64f4384f6ea1f /clang-tools-extra/clang-tidy/misc/SuspiciousMissingCommaCheck.h
parentb3c2764f8966d0b9ef19938f1f3bda72eec83533 (diff)
downloadbcm5719-llvm-1eec3f01f07c88325f9958b85dee8d33f548af52.tar.gz
bcm5719-llvm-1eec3f01f07c88325f9958b85dee8d33f548af52.zip
[clang-tidy] Reduce false-positive ratio in misc-suspicious-missing-comma check.
Summary: This patch is adding detection of common string literal patterns that should not trigger warnings. [*] Add a limit on the number of concatenated token, [*] Add support for parenthese sequence of tokens, [*] Add detection of valid indentation. As an example, this code will no longer trigger a warning: ``` const char* Array[] = { "first literal" "indented literal" "indented literal", "second literal", [...] ``` Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D18695 llvm-svn: 265303
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/SuspiciousMissingCommaCheck.h')
-rw-r--r--clang-tools-extra/clang-tidy/misc/SuspiciousMissingCommaCheck.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/SuspiciousMissingCommaCheck.h b/clang-tools-extra/clang-tidy/misc/SuspiciousMissingCommaCheck.h
index 209d7fb2bf5..21cb680a438 100644
--- a/clang-tools-extra/clang-tidy/misc/SuspiciousMissingCommaCheck.h
+++ b/clang-tools-extra/clang-tidy/misc/SuspiciousMissingCommaCheck.h
@@ -32,6 +32,8 @@ private:
const unsigned SizeThreshold;
// Maximal threshold ratio of suspicious string literals to be considered.
const double RatioThreshold;
+ // Maximal number of concatenated tokens.
+ const unsigned MaxConcatenatedTokens;
};
} // namespace misc
OpenPOWER on IntegriCloud