diff options
| author | Pavel Labath <labath@google.com> | 2016-05-11 16:59:04 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2016-05-11 16:59:04 +0000 |
| commit | 998bdc5b7536bd2726f3017a7798f25890ee8bf7 (patch) | |
| tree | 96039510ad9556fd8e02760f237f9cb2ff0bd460 /clang-tools-extra/clang-tidy/misc/StringConstructorCheck.cpp | |
| parent | 465a5041e938ef1d3d319847d08ab950f1684fa5 (diff) | |
| download | bcm5719-llvm-998bdc5b7536bd2726f3017a7798f25890ee8bf7.tar.gz bcm5719-llvm-998bdc5b7536bd2726f3017a7798f25890ee8bf7.zip | |
Generalize child process monitoring functions
Summary:
This replaces the C-style "void *" baton of the child process monitoring functions with a more
C++-like API taking a std::function. The motivation for this was that it was very difficult to
handle the ownership of the object passed into the callback function -- each caller ended up
implementing his own way of doing it, some doing it better than others. With the new API, one can
just pass a smart pointer into the callback and all of the lifetime management will be handled
automatically.
This has enabled me to simplify the rather complicated handshake in Host::RunShellCommand. I have
left handling of MonitorDebugServerProcess (my original motivation for this change) to a separate
commit to reduce the scope of this change.
Reviewers: clayborg, zturner, emaste, krytarowski
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D20106
llvm-svn: 269205
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/StringConstructorCheck.cpp')
0 files changed, 0 insertions, 0 deletions
