summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-tidy/misc/MultipleStatementMacroCheck.cpp
diff options
context:
space:
mode:
authorAlexander Kornienko <alexfh@google.com>2017-11-24 14:16:29 +0000
committerAlexander Kornienko <alexfh@google.com>2017-11-24 14:16:29 +0000
commitd4ac4afda75c9ef174e85eea7f40a6ae6cc50ab4 (patch)
treec43c0be034454ea297f0ccdc84302e9636abed63 /clang-tools-extra/clang-tidy/misc/MultipleStatementMacroCheck.cpp
parent70cdb5b3914803ca89a96a867a47936d049a4b32 (diff)
downloadbcm5719-llvm-d4ac4afda75c9ef174e85eea7f40a6ae6cc50ab4.tar.gz
bcm5719-llvm-d4ac4afda75c9ef174e85eea7f40a6ae6cc50ab4.zip
[clang-tidy] Move a few more checks from misc to bugprone.
Summary: clang_tidy/rename_check.py misc-assert-side-effect bugprone-assert-side-effect clang_tidy/rename_check.py misc-bool-pointer-implicit-conversion bugprone-bool-pointer-implicit-conversion clang_tidy/rename_check.py misc-fold-init-type bugprone-fold-init-type clang_tidy/rename_check.py misc-forward-declaration-namespace bugprone-forward-declaration-namespace clang_tidy/rename_check.py misc-inaccurate-erase bugprone-inaccurate-erase clang_tidy/rename_check.py misc-move-forwarding-reference bugprone-move-forwarding-reference clang_tidy/rename_check.py misc-multiple-statement-macro bugprone-multiple-statement-macro clang_tidy/rename_check.py misc-use-after-move bugprone-use-after-move clang_tidy/rename_check.py misc-virtual-near-miss bugprone-virtual-near-miss Manually fixed a reference to UseAfterMoveCheck in the hicpp module. Manually fixed header guards. Reviewers: hokein Reviewed By: hokein Subscribers: nemanjai, mgorny, javed.absar, xazax.hun, kbarton, cfe-commits Differential Revision: https://reviews.llvm.org/D40426 llvm-svn: 318950
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/MultipleStatementMacroCheck.cpp')
-rw-r--r--clang-tools-extra/clang-tidy/misc/MultipleStatementMacroCheck.cpp106
1 files changed, 0 insertions, 106 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/MultipleStatementMacroCheck.cpp b/clang-tools-extra/clang-tidy/misc/MultipleStatementMacroCheck.cpp
deleted file mode 100644
index 9d485fd211b..00000000000
--- a/clang-tools-extra/clang-tidy/misc/MultipleStatementMacroCheck.cpp
+++ /dev/null
@@ -1,106 +0,0 @@
-//===--- MultipleStatementMacroCheck.cpp - clang-tidy----------------------===//
-//
-// The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include "MultipleStatementMacroCheck.h"
-#include "clang/AST/ASTContext.h"
-#include "clang/ASTMatchers/ASTMatchFinder.h"
-
-using namespace clang::ast_matchers;
-
-namespace clang {
-namespace tidy {
-namespace misc {
-
-namespace {
-
-AST_MATCHER(Expr, isInMacro) { return Node.getLocStart().isMacroID(); }
-
-/// \brief Find the next statement after `S`.
-const Stmt *nextStmt(const MatchFinder::MatchResult &Result, const Stmt *S) {
- auto Parents = Result.Context->getParents(*S);
- if (Parents.empty())
- return nullptr;
- const auto *Parent = Parents[0].get<Stmt>();
- if (!Parent)
- return nullptr;
- const Stmt *Prev = nullptr;
- for (const Stmt *Child : Parent->children()) {
- if (Prev == S)
- return Child;
- Prev = Child;
- }
- return nextStmt(Result, Parent);
-}
-
-using ExpansionRanges = std::vector<std::pair<SourceLocation, SourceLocation>>;
-
-/// \bried Get all the macro expansion ranges related to `Loc`.
-///
-/// The result is ordered from most inner to most outer.
-ExpansionRanges getExpansionRanges(SourceLocation Loc,
- const MatchFinder::MatchResult &Result) {
- ExpansionRanges Locs;
- while (Loc.isMacroID()) {
- Locs.push_back(Result.SourceManager->getImmediateExpansionRange(Loc));
- Loc = Locs.back().first;
- }
- return Locs;
-}
-
-} // namespace
-
-void MultipleStatementMacroCheck::registerMatchers(MatchFinder *Finder) {
- const auto Inner = expr(isInMacro(), unless(compoundStmt())).bind("inner");
- Finder->addMatcher(
- stmt(anyOf(ifStmt(hasThen(Inner)), ifStmt(hasElse(Inner)).bind("else"),
- whileStmt(hasBody(Inner)), forStmt(hasBody(Inner))))
- .bind("outer"),
- this);
-}
-
-void MultipleStatementMacroCheck::check(
- const MatchFinder::MatchResult &Result) {
- const auto *Inner = Result.Nodes.getNodeAs<Expr>("inner");
- const auto *Outer = Result.Nodes.getNodeAs<Stmt>("outer");
- const auto *Next = nextStmt(Result, Outer);
- if (!Next)
- return;
-
- SourceLocation OuterLoc = Outer->getLocStart();
- if (Result.Nodes.getNodeAs<Stmt>("else"))
- OuterLoc = cast<IfStmt>(Outer)->getElseLoc();
-
- auto InnerRanges = getExpansionRanges(Inner->getLocStart(), Result);
- auto OuterRanges = getExpansionRanges(OuterLoc, Result);
- auto NextRanges = getExpansionRanges(Next->getLocStart(), Result);
-
- // Remove all the common ranges, starting from the top (the last ones in the
- // list).
- while (!InnerRanges.empty() && !OuterRanges.empty() && !NextRanges.empty() &&
- InnerRanges.back() == OuterRanges.back() &&
- InnerRanges.back() == NextRanges.back()) {
- InnerRanges.pop_back();
- OuterRanges.pop_back();
- NextRanges.pop_back();
- }
-
- // Inner and Next must have at least one more macro that Outer doesn't have,
- // and that range must be common to both.
- if (InnerRanges.empty() || NextRanges.empty() ||
- InnerRanges.back() != NextRanges.back())
- return;
-
- diag(InnerRanges.back().first, "multiple statement macro used without "
- "braces; some statements will be "
- "unconditionally executed");
-}
-
-} // namespace misc
-} // namespace tidy
-} // namespace clang
OpenPOWER on IntegriCloud