summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp
diff options
context:
space:
mode:
authorBenjamin Kramer <benny.kra@googlemail.com>2016-04-07 14:55:25 +0000
committerBenjamin Kramer <benny.kra@googlemail.com>2016-04-07 14:55:25 +0000
commita62e2232815e537952bd6df271763521a0472498 (patch)
treeea5a784158442dae656b208e3d436cbc624fa55b /clang-tools-extra/clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp
parent53f7c0ea8e02e2a49f13e713ec6bdbfe067e8383 (diff)
downloadbcm5719-llvm-a62e2232815e537952bd6df271763521a0472498.tar.gz
bcm5719-llvm-a62e2232815e537952bd6df271763521a0472498.zip
[clang-tidy] Remove unnecessary getName() on Decls and Types feeding into a DiagnosticBuilder
Going through a string removes some of the smarts of the diagnosic printer and makes the code more complicated. This change has some cosmetic impact on the output but that's mostly minor. llvm-svn: 265680
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp')
-rw-r--r--clang-tools-extra/clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp b/clang-tools-extra/clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp
index 24593cba172..e8ad7c57efc 100644
--- a/clang-tools-extra/clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp
@@ -65,9 +65,9 @@ void MacroRepeatedPPCallbacks::MacroExpands(const Token &MacroNameTok,
if (hasSideEffects(ResultArgToks) &&
countArgumentExpansions(MI, Arg) >= 2) {
Check.diag(ResultArgToks->getLocation(),
- "side effects in the %ordinal0 macro argument '%1' are "
+ "side effects in the %ordinal0 macro argument %1 are "
"repeated in macro expansion")
- << (ArgNo + 1) << Arg->getName();
+ << (ArgNo + 1) << Arg;
Check.diag(MI->getDefinitionLoc(), "macro %0 defined here",
DiagnosticIDs::Note)
<< MacroNameTok.getIdentifierInfo();
OpenPOWER on IntegriCloud