[clang-tidy] Fixes to misc-forwarding-reference-overload check.

* Style fixes to tests
* Make it work consistently on all platforms

Patch by András Leitereg!

llvm-svn: 300320

1 files changed, 3 insertions, 2 deletions

diff --git a/clang-tools-extra/clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp b/clang-tools-extra/clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp
index 550c116845b..0055f35f886 100644
--- a/clang-tools-extra/clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp
@@ -56,7 +56,7 @@ AST_MATCHER_P(TemplateTypeParmDecl, hasDefaultArgument,
   return Node.hasDefaultArgument() &&

          TypeMatcher.matches(Node.getDefaultArgument(), Finder, Builder);

 }

-}

+} // namespace

 

 void ForwardingReferenceOverloadCheck::registerMatchers(MatchFinder *Finder) {

   // Forwarding references require C++11 or later.

@@ -123,7 +123,8 @@ void ForwardingReferenceOverloadCheck::check(
         (OtherCtor->isCopyConstructor() ? EnabledCopy : EnabledMove) = true;

     }

   }

-  bool Copy = !DisabledCopy || EnabledCopy, Move = !DisabledMove || EnabledMove;

+  bool Copy = !EnabledMove && !DisabledMove && !DisabledCopy || EnabledCopy;

+  bool Move = !DisabledMove || EnabledMove;

   if (!Copy && !Move)

     return;

   diag(Ctor->getLocation(),