summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp
diff options
context:
space:
mode:
authorBenjamin Kramer <benny.kra@googlemail.com>2014-08-04 10:11:47 +0000
committerBenjamin Kramer <benny.kra@googlemail.com>2014-08-04 10:11:47 +0000
commitf5847cf84c4c965ea416a22f194a61c201abeb6a (patch)
tree4f688b34036374158476b4af347a75df5b0b4d4d /clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp
parent1cd57ebb6b2ca7b2dbeb893664d59c0e1ae964d2 (diff)
downloadbcm5719-llvm-f5847cf84c4c965ea416a22f194a61c201abeb6a.tar.gz
bcm5719-llvm-f5847cf84c4c965ea416a22f194a61c201abeb6a.zip
[clang-tidy] Rewrite a for-range loop in the old style.
Haven't thought that I ever needed to do this, but in this case comparing the index using pointer arithmetic turns out to be really ugly. It also generates nasty sign-compare warnings on 32 bit targets. llvm-svn: 214705
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp')
-rw-r--r--clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp b/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp
index 5357b7c92a9..4f7b535bd56 100644
--- a/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/ArgumentCommentCheck.cpp
@@ -86,10 +86,10 @@ ArgumentCommentCheck::isLikelyTypo(llvm::ArrayRef<ParmVarDecl *> Params,
if (ThisED >= UpperBound)
return false;
- for (const auto &Param : Params) {
- if (&Param - Params.begin() == ArgIndex)
+ for (unsigned I = 0, E = Params.size(); I != E; ++I) {
+ if (I == ArgIndex)
continue;
- IdentifierInfo *II = Param->getIdentifier();
+ IdentifierInfo *II = Params[I]->getIdentifier();
if (!II)
continue;
OpenPOWER on IntegriCloud