diff options
| author | Alexander Kornienko <alexfh@google.com> | 2019-04-17 22:35:36 +0000 |
|---|---|---|
| committer | Alexander Kornienko <alexfh@google.com> | 2019-04-17 22:35:36 +0000 |
| commit | 4c177038e096dad3646fe8fc33682e6ef2f590fa (patch) | |
| tree | eb34e3426fd51b3118d83a43a0e915742ccc8499 /clang-tools-extra/clang-tidy/cppcoreguidelines | |
| parent | b0c1f8c09e432e064951f6dac1ecac17a7050c37 (diff) | |
| download | bcm5719-llvm-4c177038e096dad3646fe8fc33682e6ef2f590fa.tar.gz bcm5719-llvm-4c177038e096dad3646fe8fc33682e6ef2f590fa.zip | |
[clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros
Before the patch calling clang-tidy with -header-filter=.* -system-headers would
result in a few hundred useless warnings:
warning: macro '_GNU_SOURCE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
warning: macro '_LP64' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
warning: macro '__ATOMIC_ACQUIRE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
warning: macro '__ATOMIC_ACQ_REL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
warning: macro '__ATOMIC_CONSUME' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
warning: macro '__ATOMIC_RELAXED' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
warning: macro '__ATOMIC_RELEASE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
warning: macro '__ATOMIC_SEQ_CST' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
warning: macro '__BIGGEST_ALIGNMENT__' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
... and so on
llvm-svn: 358621
Diffstat (limited to 'clang-tools-extra/clang-tidy/cppcoreguidelines')
| -rw-r--r-- | clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp b/clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp index 01c25d241a5..ac5ec130f46 100644 --- a/clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp +++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp @@ -36,7 +36,8 @@ public: IgnoreCommandLineMacros(IgnoreCommandLine) {} void MacroDefined(const Token &MacroNameTok, const MacroDirective *MD) override { - if (MD->getMacroInfo()->isUsedForHeaderGuard() || + if (SM.isWrittenInBuiltinFile(MD->getLocation()) || + MD->getMacroInfo()->isUsedForHeaderGuard() || MD->getMacroInfo()->getNumTokens() == 0) return; |
