diff options
author | Shoaib Meenai <smeenai@fb.com> | 2017-03-02 03:22:18 +0000 |
---|---|---|
committer | Shoaib Meenai <smeenai@fb.com> | 2017-03-02 03:22:18 +0000 |
commit | bda3c7df78501378a54e3c4a44d49376d6a2cdda (patch) | |
tree | dfd60ecac68e2dbc079c855fdb03cb63fb9ae8f2 /clang-tools-extra/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp | |
parent | bad28c44eb1df72ede59c1a56e09b4a2f34688c3 (diff) | |
download | bcm5719-llvm-bda3c7df78501378a54e3c4a44d49376d6a2cdda.tar.gz bcm5719-llvm-bda3c7df78501378a54e3c4a44d49376d6a2cdda.zip |
[libc++] Make _LIBCPP_TYPE_VIS export members
Summary:
Most classes annotated with _LIBCPP_TYPE_VIS need to have at least some
of their members exported, otherwise we have a lot of link errors when
linking against a libc++ built with hidden visibility. This also makes
_LIBCPP_TYPE_VIS be consistent across platforms, since on Windows it
already exports members.
With this change made, any template methods of a class marked
_LIBCPP_TYPE_VIS will also get default visibility when instantiatied,
which is not desirable for clients of libc++ headers who wish to control
their visibility; this is the same issue as PR30642. Annotate all
problematic methods with an explicit visibility specifier to avoid this.
The problematic methods were found by running bad-visibility-finder [1]
against the libc++ headers after making the _LIBCPP_TYPE_VIS change. The
small methods were marked for inlining; the larger ones hidden.
[1] https://github.com/smeenai/bad-visibility-finder
Reviewers: mclow.lists, EricWF
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25208
llvm-svn: 296732
Diffstat (limited to 'clang-tools-extra/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp')
0 files changed, 0 insertions, 0 deletions