diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2017-08-14 17:04:16 +0000 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2017-08-14 17:04:16 +0000 |
| commit | 56650e7fc58770fbfecfad746222da47cb208f5e (patch) | |
| tree | 1f1e316c2060697275b4cd1a14d0a5237b848c5e /clang-tools-extra/clang-tidy/android/CloexecCheck.cpp | |
| parent | 533d4c90bda5aa40a81671bbf8b059e91fb24925 (diff) | |
| download | bcm5719-llvm-56650e7fc58770fbfecfad746222da47cb208f5e.tar.gz bcm5719-llvm-56650e7fc58770fbfecfad746222da47cb208f5e.zip | |
[clang-tidy] Add a close-on-exec check on dup() in Android module.
Summary:
dup() is better to be replaced by fcntl() to avoid file descriptor leakage.
Differential Revision: https://reviews.llvm.org/D35364
llvm-svn: 310858
Diffstat (limited to 'clang-tools-extra/clang-tidy/android/CloexecCheck.cpp')
| -rw-r--r-- | clang-tools-extra/clang-tidy/android/CloexecCheck.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/android/CloexecCheck.cpp b/clang-tools-extra/clang-tidy/android/CloexecCheck.cpp index 9cf823a48ad..38afa137059 100644 --- a/clang-tools-extra/clang-tidy/android/CloexecCheck.cpp +++ b/clang-tools-extra/clang-tidy/android/CloexecCheck.cpp @@ -100,6 +100,15 @@ void CloexecCheck::insertStringFlag( ReplacementText); } +StringRef CloexecCheck::getSpellingArg(const MatchFinder::MatchResult &Result, + int N) const { + const auto *MatchedCall = Result.Nodes.getNodeAs<CallExpr>(FuncBindingStr); + const SourceManager &SM = *Result.SourceManager; + return Lexer::getSourceText( + CharSourceRange::getTokenRange(MatchedCall->getArg(N)->getSourceRange()), + SM, Result.Context->getLangOpts()); +} + } // namespace android } // namespace tidy } // namespace clang |

