diff options
author | Chih-Hung Hsieh <chh@google.com> | 2017-08-16 17:18:16 +0000 |
---|---|---|
committer | Chih-Hung Hsieh <chh@google.com> | 2017-08-16 17:18:16 +0000 |
commit | ae3527e6bbe8d8de2ff0fa62b1352f7d3371d6f1 (patch) | |
tree | 1a6d6496ee59ed126834a73b89fb78f45cfb1c1b /clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | |
parent | 71ecaa19ff0a6f63b1e0c9fa6d28f5fa84b8072d (diff) | |
download | bcm5719-llvm-ae3527e6bbe8d8de2ff0fa62b1352f7d3371d6f1.tar.gz bcm5719-llvm-ae3527e6bbe8d8de2ff0fa62b1352f7d3371d6f1.zip |
[clang-tidy] Add a close-on-exec check on accept() in Android module.
Summary:
accept() is better to be replaced by accept4() with SOCK_CLOEXEC
flag to avoid file descriptor leakage.
Differential Revision: https://reviews.llvm.org/D35362
llvm-svn: 311024
Diffstat (limited to 'clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp')
-rw-r--r-- | clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp index aca2d5f1ae5..fe9330dd2d2 100644 --- a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp @@ -10,6 +10,7 @@ #include "../ClangTidy.h" #include "../ClangTidyModule.h" #include "../ClangTidyModuleRegistry.h" +#include "CloexecAcceptCheck.h" #include "CloexecCreatCheck.h" #include "CloexecDupCheck.h" #include "CloexecFopenCheck.h" @@ -29,6 +30,7 @@ namespace android { class AndroidModule : public ClangTidyModule { public: void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { + CheckFactories.registerCheck<CloexecAcceptCheck>("android-cloexec-accept"); CheckFactories.registerCheck<CloexecCreatCheck>("android-cloexec-creat"); CheckFactories.registerCheck<CloexecDupCheck>("android-cloexec-dup"); CheckFactories.registerCheck<CloexecFopenCheck>("android-cloexec-fopen"); |