diff options
author | George Burgess IV <george.burgess.iv@gmail.com> | 2019-06-06 05:21:45 +0000 |
---|---|---|
committer | George Burgess IV <george.burgess.iv@gmail.com> | 2019-06-06 05:21:45 +0000 |
commit | 5b2a85d0ded21097885900889faa871fdb2e71b5 (patch) | |
tree | 040307052a8a0d7a911cf74d7c617a32cfea801c /clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | |
parent | 3da331b456214c51b1735d02d304df91930cd461 (diff) | |
download | bcm5719-llvm-5b2a85d0ded21097885900889faa871fdb2e71b5.tar.gz bcm5719-llvm-5b2a85d0ded21097885900889faa871fdb2e71b5.zip |
android: add a close-on-exec check on pipe()
On Android, pipe() is better to be replaced by pipe2() with O_CLOEXEC
flag to avoid file descriptor leakage.
Patch by Jian Cai!
Differential Revision: https://reviews.llvm.org/D61967
llvm-svn: 362673
Diffstat (limited to 'clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp')
-rw-r--r-- | clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp index 237d5ff5e8a..e97830972ce 100644 --- a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp @@ -20,6 +20,7 @@ #include "CloexecInotifyInitCheck.h" #include "CloexecMemfdCreateCheck.h" #include "CloexecOpenCheck.h" +#include "CloexecPipeCheck.h" #include "CloexecPipe2Check.h" #include "CloexecSocketCheck.h" #include "ComparisonInTempFailureRetryCheck.h" @@ -50,6 +51,7 @@ public: CheckFactories.registerCheck<CloexecMemfdCreateCheck>( "android-cloexec-memfd-create"); CheckFactories.registerCheck<CloexecOpenCheck>("android-cloexec-open"); + CheckFactories.registerCheck<CloexecPipeCheck>("android-cloexec-pipe"); CheckFactories.registerCheck<CloexecPipe2Check>("android-cloexec-pipe2"); CheckFactories.registerCheck<CloexecSocketCheck>("android-cloexec-socket"); CheckFactories.registerCheck<ComparisonInTempFailureRetryCheck>( |