diff options
author | Chih-Hung Hsieh <chh@google.com> | 2017-08-14 17:25:41 +0000 |
---|---|---|
committer | Chih-Hung Hsieh <chh@google.com> | 2017-08-14 17:25:41 +0000 |
commit | 2e6f9a16f936d3ef754cdb1bd0dd59a8680f374d (patch) | |
tree | 386fbcf3b021a529b8ea16ddd5748cdeacf57b80 /clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | |
parent | 86021a2345078c13010cb12179a1ac2af7a7d045 (diff) | |
download | bcm5719-llvm-2e6f9a16f936d3ef754cdb1bd0dd59a8680f374d.tar.gz bcm5719-llvm-2e6f9a16f936d3ef754cdb1bd0dd59a8680f374d.zip |
[clang-tidy] Add a close-on-exec check on inotify_init() in Android module.
Summary:
inotify_init() is better to be replaced by inotify_init1() with IN_CLOEXEC flag to avoid file descriptor leakage.
Differential Revision: https://reviews.llvm.org/D35370
llvm-svn: 310861
Diffstat (limited to 'clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp')
-rw-r--r-- | clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp index 71c6accba97..316d228a7b0 100644 --- a/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp @@ -13,6 +13,7 @@ #include "CloexecCreatCheck.h" #include "CloexecDupCheck.h" #include "CloexecFopenCheck.h" +#include "CloexecInotifyInitCheck.h" #include "CloexecMemfdCreateCheck.h" #include "CloexecOpenCheck.h" #include "CloexecSocketCheck.h" @@ -30,6 +31,8 @@ public: CheckFactories.registerCheck<CloexecCreatCheck>("android-cloexec-creat"); CheckFactories.registerCheck<CloexecDupCheck>("android-cloexec-dup"); CheckFactories.registerCheck<CloexecFopenCheck>("android-cloexec-fopen"); + CheckFactories.registerCheck<CloexecInotifyInitCheck>( + "android-cloexec-inotify-init"); CheckFactories.registerCheck<CloexecMemfdCreateCheck>( "android-cloexec-memfd-create"); CheckFactories.registerCheck<CloexecOpenCheck>("android-cloexec-open"); |