summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-tidy/ClangTidyModule.h
diff options
context:
space:
mode:
authorSander de Smalen <sander.desmalen@arm.com>2019-09-18 09:02:44 +0000
committerSander de Smalen <sander.desmalen@arm.com>2019-09-18 09:02:44 +0000
commitdc2a7f5b39213bdc7574cabd3131ba0215c11e8e (patch)
tree649acef1d1ffae941e5e2fcc50c282fe1573e681 /clang-tools-extra/clang-tidy/ClangTidyModule.h
parent1442efea9a045851a4c16908832f528574fb440e (diff)
downloadbcm5719-llvm-dc2a7f5b39213bdc7574cabd3131ba0215c11e8e.tar.gz
bcm5719-llvm-dc2a7f5b39213bdc7574cabd3131ba0215c11e8e.zip
[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize
This patch fixes a bug exposed by D65653 where a subsequent invocation of `determineCalleeSaves` ends up with a different size for the callee save area, leading to different frame-offsets in debug information. In the invocation by PEI, `determineCalleeSaves` tries to determine whether it needs to spill an extra callee-saved register to get an emergency spill slot. To do this, it calls 'estimateStackSize' and manually adds the size of the callee-saves to this. PEI then allocates the spill objects for the callee saves and the remaining frame layout is calculated accordingly. A second invocation in LiveDebugValues causes estimateStackSize to return the size of the stack frame including the callee-saves. Given that the size of the callee-saves is added to this, these callee-saves are counted twice, which leads `determineCalleeSaves` to believe the stack has become big enough to require spilling an extra callee-save as emergency spillslot. It then updates CalleeSavedStackSize with a larger value. Since CalleeSavedStackSize is used in the calculation of the frame offset in getFrameIndexReference, this leads to incorrect offsets for variables/locals when this information is recalculated after PEI. Reviewers: omjavaid, eli.friedman, thegameg, efriedma Reviewed By: efriedma Differential Revision: https://reviews.llvm.org/D66935 llvm-svn: 372204
Diffstat (limited to 'clang-tools-extra/clang-tidy/ClangTidyModule.h')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud