summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-rename/USRLocFinder.cpp
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@vmiklos.hu>2016-05-17 18:17:16 +0000
committerMiklos Vajna <vmiklos@vmiklos.hu>2016-05-17 18:17:16 +0000
commita7445f1b5ec28666d5a5b51210e97572c73f32c3 (patch)
tree42b94822cc576c8a197ba6387b02ae204660693c /clang-tools-extra/clang-rename/USRLocFinder.cpp
parentbf2b614b8aa046cc65de0664e037d77d3cdceb1d (diff)
downloadbcm5719-llvm-a7445f1b5ec28666d5a5b51210e97572c73f32c3.tar.gz
bcm5719-llvm-a7445f1b5ec28666d5a5b51210e97572c73f32c3.zip
clang-rename: avoid StringRef members in USRLocFindingASTVisitor
Even if this is defined in the .cpp file and only used as part of the function (so here it's safe), usually storing StringRefs in the class is dangerous, so don't do so. Reviewers: cfe-commits, klimek Differential Revision: http://reviews.llvm.org/D20296 llvm-svn: 269796
Diffstat (limited to 'clang-tools-extra/clang-rename/USRLocFinder.cpp')
-rw-r--r--clang-tools-extra/clang-rename/USRLocFinder.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/clang-tools-extra/clang-rename/USRLocFinder.cpp b/clang-tools-extra/clang-rename/USRLocFinder.cpp
index ca4cf25268b..9a2356b1e06 100644
--- a/clang-tools-extra/clang-rename/USRLocFinder.cpp
+++ b/clang-tools-extra/clang-rename/USRLocFinder.cpp
@@ -123,9 +123,9 @@ private:
}
// All the locations of the USR were found.
- StringRef USR;
+ const std::string USR;
// Old name that is renamed.
- StringRef PrevName;
+ const std::string PrevName;
std::vector<clang::SourceLocation> LocationsFound;
};
} // namespace
OpenPOWER on IntegriCloud