summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Jasper <djasper@google.com>2012-10-08 18:31:54 +0000
committerDaniel Jasper <djasper@google.com>2012-10-08 18:31:54 +0000
commitfddb32c3d6775d0a8e6f2d0bbbbddcdb96c4a2c3 (patch)
tree7dc8d436100b39e2ca805a07dadf5206308a67c5
parent22b9fd2f2e4e7b5f056d685a9ecb94e037beb646 (diff)
downloadbcm5719-llvm-fddb32c3d6775d0a8e6f2d0bbbbddcdb96c4a2c3.tar.gz
bcm5719-llvm-fddb32c3d6775d0a8e6f2d0bbbbddcdb96c4a2c3.zip
FileNameMatchTrie: Use StringRef instead of Twines where possible.
llvm-svn: 165412
-rw-r--r--clang/include/clang/Tooling/FileMatchTrie.h3
-rw-r--r--clang/lib/Tooling/FileMatchTrie.cpp5
-rw-r--r--clang/unittests/Tooling/CompilationDatabaseTest.cpp4
3 files changed, 5 insertions, 7 deletions
diff --git a/clang/include/clang/Tooling/FileMatchTrie.h b/clang/include/clang/Tooling/FileMatchTrie.h
index 14c823ba5ec..ff988bebf2c 100644
--- a/clang/include/clang/Tooling/FileMatchTrie.h
+++ b/clang/include/clang/Tooling/FileMatchTrie.h
@@ -18,7 +18,6 @@
#include "clang/Basic/LLVM.h"
#include "llvm/ADT/OwningPtr.h"
#include "llvm/ADT/StringRef.h"
-#include "llvm/ADT/Twine.h"
#include <string>
#include <vector>
@@ -28,7 +27,7 @@ namespace tooling {
struct PathComparator {
virtual ~PathComparator() {}
- virtual bool equivalent(const Twine &FileA, const Twine &FileB) const = 0;
+ virtual bool equivalent(StringRef FileA, StringRef FileB) const = 0;
};
class FileMatchTrieNode;
diff --git a/clang/lib/Tooling/FileMatchTrie.cpp b/clang/lib/Tooling/FileMatchTrie.cpp
index b16b044245a..9b1be62875a 100644
--- a/clang/lib/Tooling/FileMatchTrie.cpp
+++ b/clang/lib/Tooling/FileMatchTrie.cpp
@@ -23,9 +23,8 @@ namespace tooling {
/// \brief Default \c PathComparator using \c llvm::sys::fs::equivalent().
struct DefaultPathComparator : public PathComparator {
virtual ~DefaultPathComparator() {}
- virtual bool equivalent(const Twine &FileA, const Twine &FileB) const {
- return FileA.str() == FileB.str() ||
- llvm::sys::fs::equivalent(FileA, FileB);
+ virtual bool equivalent(StringRef FileA, StringRef FileB) const {
+ return FileA == FileB || llvm::sys::fs::equivalent(FileA, FileB);
}
};
diff --git a/clang/unittests/Tooling/CompilationDatabaseTest.cpp b/clang/unittests/Tooling/CompilationDatabaseTest.cpp
index 5bbbe2aa2e7..6b58abbd325 100644
--- a/clang/unittests/Tooling/CompilationDatabaseTest.cpp
+++ b/clang/unittests/Tooling/CompilationDatabaseTest.cpp
@@ -84,8 +84,8 @@ static CompileCommand findCompileArgsInJsonDatabase(StringRef FileName,
struct FakeComparator : public PathComparator {
virtual ~FakeComparator() {}
- virtual bool equivalent(const Twine &FileA, const Twine &FileB) const {
- return StringRef(FileA.str()).equals_lower(FileB.str());
+ virtual bool equivalent(StringRef FileA, StringRef FileB) const {
+ return FileA.equals_lower(FileB);
}
};
OpenPOWER on IntegriCloud