summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFariborz Jahanian <fjahanian@apple.com>2010-02-24 01:25:40 +0000
committerFariborz Jahanian <fjahanian@apple.com>2010-02-24 01:25:40 +0000
commitf89eb2b9c241eaabdf998114c4f65ce67c97e013 (patch)
treec25a02cfe5d4fd32fa035ccadd4272e60d483c50
parenta2d8c97b65e343c9b7af02929ebc804b1eb15031 (diff)
downloadbcm5719-llvm-f89eb2b9c241eaabdf998114c4f65ce67c97e013.tar.gz
bcm5719-llvm-f89eb2b9c241eaabdf998114c4f65ce67c97e013.zip
Fix rewriting of a method when return type is
a block pointer type. Fixes radar 7682149. llvm-svn: 97008
-rw-r--r--clang/lib/Frontend/RewriteObjC.cpp4
-rw-r--r--clang/test/Rewriter/rewrite-block-pointer.mm25
2 files changed, 29 insertions, 0 deletions
diff --git a/clang/lib/Frontend/RewriteObjC.cpp b/clang/lib/Frontend/RewriteObjC.cpp
index 0156d1da91d..521abf489b9 100644
--- a/clang/lib/Frontend/RewriteObjC.cpp
+++ b/clang/lib/Frontend/RewriteObjC.cpp
@@ -2815,6 +2815,10 @@ Stmt *RewriteObjC::SynthMessageExpr(ObjCMessageExpr *Exp,
}
returnType = OMD->getResultType()->isObjCQualifiedIdType()
? Context->getObjCIdType() : OMD->getResultType();
+ if (isTopLevelBlockPointerType(returnType)) {
+ const BlockPointerType *BPT = returnType->getAs<BlockPointerType>();
+ returnType = Context->getPointerType(BPT->getPointeeType());
+ }
} else {
returnType = Context->getObjCIdType();
}
diff --git a/clang/test/Rewriter/rewrite-block-pointer.mm b/clang/test/Rewriter/rewrite-block-pointer.mm
index 4a4fa347084..8698b93c182 100644
--- a/clang/test/Rewriter/rewrite-block-pointer.mm
+++ b/clang/test/Rewriter/rewrite-block-pointer.mm
@@ -3,6 +3,7 @@
// radar 7638400
typedef void * id;
+void *sel_registerName(const char *);
@interface X
@end
@@ -33,3 +34,27 @@ void *_Block_copy(const void *aBlock);
void x(void (^block)(void)) {
block = ((__typeof(block))_Block_copy((const void *)(block)));
}
+
+// radar 7682149
+@interface Y {
+@private
+ id _private;
+}
+- (void (^)(void))f;
+@end
+
+typedef void (^void_block_t)(void);
+
+@interface YY {
+ void_block_t __completion;
+}
+@property (copy) void_block_t f;
+@end
+
+@implementation Y
+- (void (^)(void))f {
+ return [_private f];
+}
+
+@end
+
OpenPOWER on IntegriCloud