diff options
| author | Bruno Cardoso Lopes <bruno.cardoso@gmail.com> | 2011-09-01 18:15:06 +0000 |
|---|---|---|
| committer | Bruno Cardoso Lopes <bruno.cardoso@gmail.com> | 2011-09-01 18:15:06 +0000 |
| commit | f61d1c072e368327559601522f16f43bfa6431b6 (patch) | |
| tree | d776526826f9a6edbe057404d45a14e1ffcc2d6a | |
| parent | f39c67685bf46e46ea9734a4da205595f0abe01a (diff) | |
| download | bcm5719-llvm-f61d1c072e368327559601522f16f43bfa6431b6.tar.gz bcm5719-llvm-f61d1c072e368327559601522f16f43bfa6431b6.zip | |
Fix vbroadcast matching logic to early unmatch if the node doesn't have
only one use. Fix PR10825.
llvm-svn: 138951
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 6 | ||||
| -rw-r--r-- | llvm/test/CodeGen/X86/avx-vbroadcast.ll | 10 |
2 files changed, 15 insertions, 1 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 0d454149301..706b1a2f80c 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -6409,12 +6409,16 @@ static bool isVectorBroadcast(SDValue &Op) { if (Is256) V = V.getOperand(1); - if (V.hasOneUse() && V.getOpcode() != ISD::SCALAR_TO_VECTOR) + + if (!V.hasOneUse()) return false; // Check the source scalar_to_vector type. 256-bit broadcasts are // supported for 32/64-bit sizes, while 128-bit ones are only supported // for 32-bit scalars. + if (V.getOpcode() != ISD::SCALAR_TO_VECTOR) + return false; + unsigned ScalarSize = V.getOperand(0).getValueType().getSizeInBits(); if (ScalarSize != 32 && ScalarSize != 64) return false; diff --git a/llvm/test/CodeGen/X86/avx-vbroadcast.ll b/llvm/test/CodeGen/X86/avx-vbroadcast.ll index ffa9710677c..89b41884401 100644 --- a/llvm/test/CodeGen/X86/avx-vbroadcast.ll +++ b/llvm/test/CodeGen/X86/avx-vbroadcast.ll @@ -75,6 +75,7 @@ entry: ; CHECK: _G ; CHECK-NOT: vbroadcastsd (% +; CHECK: ret define <2 x i64> @G(i64* %ptr) nounwind uwtable readnone ssp { entry: %q = load i64* %ptr, align 8 @@ -82,3 +83,12 @@ entry: %vecinit2.i = insertelement <2 x i64> %vecinit.i, i64 %q, i32 1 ret <2 x i64> %vecinit2.i } + +; CHECK: _H +; CHECK-NOT: vbroadcastss +; CHECK: ret +define <4 x i32> @H(<4 x i32> %a) { + %x = shufflevector <4 x i32> %a, <4 x i32> undef, <4 x i32> <i32 1, i32 undef, i32 undef, i32 undef> + ret <4 x i32> %x +} + |
