diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-04 23:53:15 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-04 23:53:15 +0000 |
| commit | f42c58d2ef60918da6bbcab8f690271c61ce3aa1 (patch) | |
| tree | 95aea9b119b61963515b04bb781f61cb2829ab56 | |
| parent | 81f136f94a0a72706b0b670b0022fffe52dd3da1 (diff) | |
| download | bcm5719-llvm-f42c58d2ef60918da6bbcab8f690271c61ce3aa1.tar.gz bcm5719-llvm-f42c58d2ef60918da6bbcab8f690271c61ce3aa1.zip | |
Small fix for llvm-nm handling of weak symbols on ELF (print 'v').
llvm-svn: 200808
| -rw-r--r-- | llvm/test/Object/Inputs/weak.elf-x86-64 | bin | 0 -> 896 bytes | |||
| -rw-r--r-- | llvm/test/Object/nm-trivial-object.test | 6 | ||||
| -rw-r--r-- | llvm/tools/llvm-nm/llvm-nm.cpp | 8 |
3 files changed, 12 insertions, 2 deletions
diff --git a/llvm/test/Object/Inputs/weak.elf-x86-64 b/llvm/test/Object/Inputs/weak.elf-x86-64 Binary files differnew file mode 100644 index 00000000000..e45f9880f9d --- /dev/null +++ b/llvm/test/Object/Inputs/weak.elf-x86-64 diff --git a/llvm/test/Object/nm-trivial-object.test b/llvm/test/Object/nm-trivial-object.test index d13d217d2f1..c2d2ebb14b5 100644 --- a/llvm/test/Object/nm-trivial-object.test +++ b/llvm/test/Object/nm-trivial-object.test @@ -6,6 +6,8 @@ RUN: llvm-nm %p/Inputs/trivial-object-test.elf-i386 \ RUN: | FileCheck %s -check-prefix ELF RUN: llvm-nm %p/Inputs/trivial-object-test.elf-x86-64 \ RUN: | FileCheck %s -check-prefix ELF +RUN: llvm-nm %p/Inputs/weak.elf-x86-64 \ +RUN: | FileCheck %s -check-prefix WEAK-ELF RUN: llvm-nm %p/Inputs/trivial-object-test.macho-i386 \ RUN: | FileCheck %s -check-prefix macho RUN: llvm-nm %p/Inputs/trivial-object-test.macho-x86-64 \ @@ -34,6 +36,10 @@ ELF: U SomeOtherFunction ELF: 00000000 T main ELF: U puts +WEAK-ELF: w f1 +WEAK-ELF: 00000000 W f2 +WEAK-ELF: v x1 +WEAK-ELF: 00000000 V x2 macho: 00000000 U _SomeOtherFunction macho: 00000000 T _main diff --git a/llvm/tools/llvm-nm/llvm-nm.cpp b/llvm/tools/llvm-nm/llvm-nm.cpp index 5b8bafc8ab0..8d1fa729bd7 100644 --- a/llvm/tools/llvm-nm/llvm-nm.cpp +++ b/llvm/tools/llvm-nm/llvm-nm.cpp @@ -360,8 +360,12 @@ static char getSymbolNMTypeChar(ELFObjectFile<ELFT> &Obj, symbol_iterator I) { Ret = ::toupper(Ret); break; case ELF::STB_WEAK: - if (EF.getSymbolTableIndex(ESym) == ELF::SHN_UNDEF) - Ret = 'w'; + if (EF.getSymbolTableIndex(ESym) == ELF::SHN_UNDEF) { + if (ESym->getType() == ELF::STT_OBJECT) + Ret = 'v'; + else + Ret = 'w'; + } else if (ESym->getType() == ELF::STT_OBJECT) Ret = 'V'; else |
