diff options
| author | Alexey Samsonov <vonosmas@gmail.com> | 2015-10-26 20:12:29 +0000 |
|---|---|---|
| committer | Alexey Samsonov <vonosmas@gmail.com> | 2015-10-26 20:12:29 +0000 |
| commit | f3ecfd3af4b0200cf8c928abf4f29e41e83d881a (patch) | |
| tree | e97ed6a00e3ce94dfabc66866b13d61f680e9a04 | |
| parent | 1d3f3271ac99412029d48902d1b4783f9681d4f9 (diff) | |
| download | bcm5719-llvm-f3ecfd3af4b0200cf8c928abf4f29e41e83d881a.tar.gz bcm5719-llvm-f3ecfd3af4b0200cf8c928abf4f29e41e83d881a.zip | |
[LLVMSymbolize] Use symbol table only if function linkage name was requested.
Now it's enough to just specify -functions=short without additionally
providing -use-symbol-table=false.
llvm-svn: 251339
| -rw-r--r-- | llvm/lib/DebugInfo/Symbolize/Symbolize.cpp | 6 | ||||
| -rw-r--r-- | llvm/test/DebugInfo/llvm-symbolizer.test | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp index 303b6d4236a..6c81ec63283 100644 --- a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp +++ b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp @@ -209,7 +209,8 @@ DILineInfo ModuleInfo::symbolizeCode( ModuleOffset, getDILineInfoSpecifier(Opts)); } // Override function name from symbol table if necessary. - if (Opts.PrintFunctions != FunctionNameKind::None && Opts.UseSymbolTable) { + if (Opts.PrintFunctions == FunctionNameKind::LinkageName && + Opts.UseSymbolTable) { std::string FunctionName; uint64_t Start, Size; if (getNameFromSymbolTable(SymbolRef::ST_Function, ModuleOffset, @@ -233,7 +234,8 @@ DIInliningInfo ModuleInfo::symbolizeInlinedCode( InlinedContext.addFrame(DILineInfo()); } // Override the function name in lower frame with name from symbol table. - if (Opts.PrintFunctions != FunctionNameKind::None && Opts.UseSymbolTable) { + if (Opts.PrintFunctions == FunctionNameKind::LinkageName && + Opts.UseSymbolTable) { DIInliningInfo PatchedInlinedContext; for (uint32_t i = 0, n = InlinedContext.getNumberOfFrames(); i < n; i++) { DILineInfo LineInfo = InlinedContext.getFrame(i); diff --git a/llvm/test/DebugInfo/llvm-symbolizer.test b/llvm/test/DebugInfo/llvm-symbolizer.test index 8a2aaaab3a3..69619b0261d 100644 --- a/llvm/test/DebugInfo/llvm-symbolizer.test +++ b/llvm/test/DebugInfo/llvm-symbolizer.test @@ -154,7 +154,7 @@ RUN: | FileCheck %s --check-prefix=STRIPPED STRIPPED: global_func RUN: echo "%p/Inputs/dwarfdump-test4.elf-x86-64 0x62c" > %t.input7 -RUN: llvm-symbolizer --functions=short --use-symbol-table=false --demangle=false < %t.input7 \ +RUN: llvm-symbolizer --functions=short --demangle=false < %t.input7 \ RUN: | FileCheck %s --check-prefix=SHORT_FUNCTION_NAME SHORT_FUNCTION_NAME-NOT: _Z1cv |
