summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSam McCall <sam.mccall@gmail.com>2019-07-18 15:00:38 +0000
committerSam McCall <sam.mccall@gmail.com>2019-07-18 15:00:38 +0000
commitf1c05e8d200840241e829af1e569ef10ba033ec5 (patch)
tree4c2e3065bb2db9cbda7b7b9e1602e67fc27f6d9e
parente43ce1a958aa0c2da41961f77a4dbd7ff97487e0 (diff)
downloadbcm5719-llvm-f1c05e8d200840241e829af1e569ef10ba033ec5.tar.gz
bcm5719-llvm-f1c05e8d200840241e829af1e569ef10ba033ec5.zip
[clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670
llvm-svn: 366443
-rw-r--r--clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp b/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
index 4bba9cec9d5..985993a3d93 100644
--- a/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
+++ b/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
@@ -128,6 +128,11 @@ public:
TypeWithKeyword::getTagTypeKindName(Record->getTagKind()));
}
Intent intent() const override { return Info; }
+ // FIXME: this is interesting to most users. However:
+ // - triggering is too broad (e.g. triggers on comments within a class)
+ // - showMessage has inconsistent UX (e.g. newlines are stripped in VSCode)
+ // - the output itself is a bit hard to decipher.
+ bool hidden() const override { return true; }
private:
const RecordDecl *Record = nullptr;
OpenPOWER on IntegriCloud